Skip to content

Commit ee29052

Browse files
committed
fix: rename misleading \$isFinal variable to \$isTrait in IsTraitTest
Variable was copy-pasted from IsFinalTest without being renamed, causing confusion despite the test itself being correct. https://claude.ai/code/session_01WXeXUHXmMjTwxx3RtBNh9B
1 parent 9498feb commit ee29052

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

tests/Unit/Expressions/ForClasses/IsTraitTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,26 +13,26 @@ class IsTraitTest extends TestCase
1313
{
1414
public function test_it_should_return_violation_error(): void
1515
{
16-
$isFinal = new IsTrait();
16+
$isTrait = new IsTrait();
1717

1818
$classDescription = (new ClassDescriptionBuilder())
1919
->setFilePath('src/Foo.php')
2020
->setClassName('HappyIsland')
2121
->build();
2222

2323
$because = 'we want to add this rule for our software';
24-
$violationError = $isFinal->describe($classDescription, $because)->toString();
24+
$violationError = $isTrait->describe($classDescription, $because)->toString();
2525

2626
$violations = new Violations();
27-
$isFinal->evaluate($classDescription, $violations, $because);
27+
$isTrait->evaluate($classDescription, $violations, $because);
2828

2929
self::assertNotEquals(0, $violations->count());
3030
self::assertEquals('HappyIsland should be trait because we want to add this rule for our software', $violationError);
3131
}
3232

3333
public function test_it_should_return_true_if_is_trait(): void
3434
{
35-
$isFinal = new IsTrait();
35+
$isTrait = new IsTrait();
3636

3737
$classDescription = (new ClassDescriptionBuilder())
3838
->setFilePath('src/Foo.php')
@@ -42,7 +42,7 @@ public function test_it_should_return_true_if_is_trait(): void
4242

4343
$because = 'we want to add this rule for our software';
4444
$violations = new Violations();
45-
$isFinal->evaluate($classDescription, $violations, $because);
45+
$isTrait->evaluate($classDescription, $violations, $because);
4646

4747
self::assertEquals(0, $violations->count());
4848
}

0 commit comments

Comments
 (0)