Fix: tests

Author: tatevikg1

src/Subscription/Controller/SubscriberController.php

@@ -169,7 +169,11 @@ public function updateSubscriber(
         }
         /** @var UpdateSubscriberRequest $updateSubscriberRequest */
         $updateSubscriberRequest = $this->validator->validate($request, UpdateSubscriberRequest::class);
-        $subscriber = $this->subscriberManager->updateSubscriber($subscriber, $updateSubscriberRequest->getDto(), $admin);
+        $subscriber = $this->subscriberManager->updateSubscriber(
+            subscriber: $subscriber,
+            subscriberDto: $updateSubscriberRequest->getDto(),
+            admin: $admin
+        );
         $this->entityManager->flush();
         $subscriberData = $this->subscriberNormalizer->normalize($subscriber, 'json');
 

src/Subscription/Request/UpdateSubscriberRequest.php

@@ -26,8 +26,6 @@
 )]
 class UpdateSubscriberRequest implements RequestInterface
 {
-    public int $subscriberId;
-
     #[Assert\NotBlank]
     #[Assert\Email]
     #[UniqueEmail(entityClass: Subscriber::class)]
@@ -51,7 +49,6 @@ class UpdateSubscriberRequest implements RequestInterface
     public function getDto(): UpdateSubscriberDto
     {
         return new UpdateSubscriberDto(
-            subscriberId: $this->subscriberId,
             email: $this->email,
             confirmed: $this->confirmed,
             blacklisted: $this->blacklisted,

tests/Unit/Identity/Request/UpdateAdministratorRequestTest.php

@@ -13,7 +13,6 @@ class UpdateAdministratorRequestTest extends TestCase
     public function testGetDtoReturnsCorrectDto(): void
     {
         $request = new UpdateAdministratorRequest();
-        $request->administratorId = 123;
         $request->loginName = 'testuser';
         $request->password = 'password123';
         $request->email = 'test@example.com';
@@ -27,7 +26,6 @@ public function testGetDtoReturnsCorrectDto(): void
 
         $dto = $request->getDto();
 
-        $this->assertEquals(123, $dto->administratorId);
         $this->assertEquals('testuser', $dto->loginName);
         $this->assertEquals('password123', $dto->password);
         $this->assertEquals('test@example.com', $dto->email);
@@ -43,11 +41,9 @@ public function testGetDtoReturnsCorrectDto(): void
     public function testGetDtoWithNullValues(): void
     {
         $request = new UpdateAdministratorRequest();
-        $request->administratorId = 456;
 
         $dto = $request->getDto();
 
-        $this->assertEquals(456, $dto->administratorId);
         $this->assertNull($dto->loginName);
         $this->assertNull($dto->password);
         $this->assertNull($dto->email);

tests/Unit/Messaging/Request/UpdateMessageRequestTest.php

@@ -53,7 +53,6 @@ protected function setUp(): void
         $scheduleRequest->method('getDto')->willReturn($this->scheduleDto);
 
         $this->request = new UpdateMessageRequest();
-        $this->request->messageId = 123;
         $this->request->content = $contentRequest;
         $this->request->format = $formatRequest;
         $this->request->metadata = $metadataRequest;
@@ -68,7 +67,6 @@ public function testGetDtoReturnsCorrectDto(): void
         $dto = $this->request->getDto();
 
         $this->assertInstanceOf(UpdateMessageDto::class, $dto);
-        $this->assertEquals(123, $dto->messageId);
         $this->assertSame($this->contentDto, $dto->content);
         $this->assertSame($this->formatDto, $dto->format);
         $this->assertSame($this->metadataDto, $dto->metadata);
@@ -84,7 +82,6 @@ public function testGetDtoWithNullTemplateId(): void
         $dto = $this->request->getDto();
 
         $this->assertInstanceOf(UpdateMessageDto::class, $dto);
-        $this->assertEquals(123, $dto->messageId);
         $this->assertSame($this->contentDto, $dto->content);
         $this->assertSame($this->formatDto, $dto->format);
         $this->assertSame($this->metadataDto, $dto->metadata);

tests/Unit/Subscription/Request/UpdateSubscriberRequestTest.php

@@ -13,7 +13,6 @@ class UpdateSubscriberRequestTest extends TestCase
     public function testGetDtoReturnsCorrectDto(): void
     {
         $request = new UpdateSubscriberRequest();
-        $request->subscriberId = 123;
         $request->email = 'subscriber@example.com';
         $request->confirmed = true;
         $request->blacklisted = false;
@@ -24,7 +23,6 @@ public function testGetDtoReturnsCorrectDto(): void
         $dto = $request->getDto();
 
         $this->assertInstanceOf(UpdateSubscriberDto::class, $dto);
-        $this->assertEquals(123, $dto->subscriberId);
         $this->assertEquals('subscriber@example.com', $dto->email);
         $this->assertTrue($dto->confirmed);
         $this->assertFalse($dto->blacklisted);