mbstring: Do functions marked “TODO Return void” require an RFC to change return type?

[arshidkv12]

Hi,

In ext/mbstring/php_mbregex.c, I noticed several places with comments like:

// TODO Return void
RETURN_TRUE;

ext/mbstring/php_mbregex.c:1567

This suggests the intent is to change these functions to return void instead of bool.

Before preparing a patch, I wanted to confirm the process:

Would changing these functions from returning true to void (i.e., RETURN_NULL() in C and updating stubs to: void) require an RFC?
Or is this considered a minor/internal API cleanup that can go directly as a PR?

I’m aware that this could have a userland impact if the return value is currently used, so I wanted to check what the preferred approach is.

Happy to prepare a PR once the direction is clarified.

Thanks!

[youkidearitai]

Hi, thank you for your feedback.
However, mbregex and php_mbregex.c accepted to deprecate in 8.6 and delete in 9.0.
https://wiki.php.net/rfc/eol-oniguruma

So I think that I can't accept your patch.
Because this code will be delete.

Thank you very much for checking source code.

[arshidkv12]

You are welcome

[arshidkv12]

I am seeing // TODO Return void and RETURN_TRUE; not only in the mbstring extension, but in other extensions as well. Does this need an RFC?

[youkidearitai]

I think don't need an RFC. I suggest create a pull request. So each extension maintainers watches and decide it.