opcache: tests for file-scope const inlining edge cases

Author: wilaak

ext/opcache/tests/pass1_const_inline_002.phpt

@@ -20,10 +20,19 @@ function use_global_const_fqn() {
 
 class MyClass {
     const CLASS_CONST = 99;
+    final const FINAL_CLASS_CONST = 77;
 
     public function use_class_const() {
         return self::CLASS_CONST;
     }
+
+    public function use_static_class_const() {
+        return static::CLASS_CONST;
+    }
+
+    public function use_static_final_class_const() {
+        return static::FINAL_CLASS_CONST;
+    }
 }
 
 function use_class_const_static() {
@@ -62,3 +71,16 @@ MyClass::use_class_const:
      ; (after optimizer)
      ; %s
 0000 RETURN int(99)
+
+MyClass::use_static_class_const:
+     ; (lines=%d, args=%d, vars=%d, tmps=%d)
+     ; (after optimizer)
+     ; %s
+0000 T%d = FETCH_CLASS_CONSTANT (static) (exception) string("CLASS_CONST")
+0001 RETURN %s
+
+MyClass::use_static_final_class_const:
+     ; (lines=%d, args=%d, vars=%d, tmps=%d)
+     ; (after optimizer)
+     ; %s
+0000 RETURN int(77)

ext/opcache/tests/pass1_const_inline_005.inc

@@ -0,0 +1,2 @@
+<?php
+const EXTERNAL_CONST = 42;

ext/opcache/tests/pass1_const_inline_005.phpt

@@ -0,0 +1,38 @@
+--TEST--
+const declared only in a separate required file is not inlined by the optimizer
+--EXTENSIONS--
+opcache
+--INI--
+opcache.enable_cli=1
+opcache.opt_debug_level=0x20000
+--FILE--
+<?php
+
+require __DIR__ . '/pass1_const_inline_005.inc';
+
+function use_external_const() {
+    return EXTERNAL_CONST;
+}
+
+?>
+--EXPECTF--
+$_main:
+     ; (lines=%d, args=%d, vars=%d, tmps=%d)
+     ; (after optimizer)
+     ; %s
+0000 INCLUDE_OR_EVAL (require) string("%s")
+0001 RETURN int(1)
+
+use_external_const:
+     ; (lines=%d, args=%d, vars=%d, tmps=%d)
+     ; (after optimizer)
+     ; %s
+0000 T%d = FETCH_CONSTANT string("EXTERNAL_CONST")
+0001 RETURN %s
+
+$_main:
+     ; (lines=%d, args=%d, vars=%d, tmps=%d)
+     ; (after optimizer)
+     ; %s
+0000 DECLARE_CONST string("EXTERNAL_CONST") int(42)
+0001 RETURN int(1)

ext/opcache/tests/pass1_const_inline_006.inc

@@ -0,0 +1,2 @@
+<?php
+const SHARED_CONST = 42;

ext/opcache/tests/pass1_const_inline_006.phpt

@@ -0,0 +1,50 @@
+--TEST--
+const redeclared after being declared in a separate required file: optimizer inlines local value, runtime warning
+--EXTENSIONS--
+opcache
+--INI--
+opcache.enable_cli=1
+opcache.opt_debug_level=0x20000
+--FILE--
+<?php
+
+require __DIR__ . '/pass1_const_inline_006.inc';
+
+const SHARED_CONST = 99;
+
+function use_shared_const() {
+    return SHARED_CONST;
+}
+
+var_dump(use_shared_const());
+
+?>
+--EXPECTF--
+$_main:
+     ; (lines=%d, args=%d, vars=%d, tmps=%d)
+     ; (after optimizer)
+     ; %s
+0000 INCLUDE_OR_EVAL (require) string("%s")
+0001 DECLARE_CONST string("SHARED_CONST") int(99)
+0002 INIT_FCALL 1 %d string("var_dump")
+0003 INIT_FCALL 0 %d string("use_shared_const")
+0004 T%d = DO_UCALL
+0005 SEND_VAL T%d 1
+0006 DO_ICALL
+0007 RETURN int(1)
+
+use_shared_const:
+     ; (lines=%d, args=%d, vars=%d, tmps=%d)
+     ; (after optimizer)
+     ; %s
+0000 RETURN int(99)
+
+$_main:
+     ; (lines=%d, args=%d, vars=%d, tmps=%d)
+     ; (after optimizer)
+     ; %s
+0000 DECLARE_CONST string("SHARED_CONST") int(42)
+0001 RETURN int(1)
+
+Warning: Constant SHARED_CONST already defined, this will be an error in PHP 9 in %s on line %d
+int(99)