Skip to content

Commit b5d39fb

Browse files
committed
address feedback
1 parent 26cb5b2 commit b5d39fb

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

ext/reflection/php_reflection.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6732,7 +6732,6 @@ ZEND_METHOD(ReflectionProperty, isReadable)
67326732
ZVAL_STR(&member, ref->unmangled_name);
67336733
zend_call_known_instance_method_with_1_params(ce->__isset, obj, return_value, &member);
67346734

6735-
// if it's a reference, unwrap
67366735
if (Z_TYPE_P(return_value) == IS_REFERENCE) {
67376736
zend_unwrap_reference(return_value);
67386737
}

ext/reflection/tests/gh22000.phpt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
--TEST--
2-
GH-22000 - Ensure __isset is not returning a reference in ReflectionProperty::isReadable()
2+
GH-22000 - Ensure __isset is supported by ReflectionProperty::isReadable()
33
--FILE--
44
<?php
55
class TestClass1 {
@@ -54,8 +54,8 @@ b from global:bool(true)
5454
c from global:bool(false)
5555
d from global:bool(false)
5656
e from global:
57-
Notice: Only variable references should be returned by reference in %s%eext%ereflection%etests%egh22000.php on line %d
57+
Notice: Only variable references should be returned by reference in %s on line %d
5858
bool(false)
5959
f from global:
60-
Notice: Only variable references should be returned by reference in %s%eext%ereflection%etests%egh22000.php on line %d
60+
Notice: Only variable references should be returned by reference in %s on line %d
6161
bool(true)

0 commit comments

Comments
 (0)