Skip to content

Commit a294d3e

Browse files
ext/curl: Deprecate the NTLM_WB constants
1 parent 3eaa338 commit a294d3e

5 files changed

Lines changed: 40 additions & 3 deletions

File tree

NEWS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ PHP NEWS
1919
and CURL_SEEKFUNC_CANTSEEK constants, letting libcurl rewind a streamed
2020
request body to resend it on a redirect, multi-pass authentication or a
2121
retried reused connection. (GrahamCampbell)
22+
. Deprecated the CURLAUTH_NTLM_WB and CURL_VERSION_NTLM_WB constants, as
23+
libcurl 8.8.0 removed NTLM_WB support. (Graham Campbell)
2224

2325
- Date:
2426
. Update timelib to 2022.17. (Derick)

UPGRADING

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,10 @@ PHP 8.6 UPGRADE NOTES
333333
. Making __construct() and __destruct() a Generator is now deprecated.
334334
RFC: https://wiki.php.net/rfc/deprecate-return-value-from-construct
335335

336+
- Curl:
337+
. The CURLAUTH_NTLM_WB and CURL_VERSION_NTLM_WB constants are deprecated, as
338+
libcurl 8.8.0 removed NTLM_WB support.
339+
336340
- GMP
337341
. The shift (<<, >>) and exponentiation (**) operators on GMP objects now
338342
emit a deprecation warning when converting a float right operand to int

ext/curl/curl.stub.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2410,6 +2410,7 @@
24102410
* @var int
24112411
* @cvalue CURLAUTH_NTLM_WB
24122412
*/
2413+
#[\Deprecated(since: '8.6', message: 'as libcurl 8.8.0 removed NTLM_WB support')]
24132414
const CURLAUTH_NTLM_WB = UNKNOWN;
24142415
/**
24152416
* @var int
@@ -2430,6 +2431,7 @@
24302431
* @var int
24312432
* @cvalue CURL_VERSION_NTLM_WB
24322433
*/
2434+
#[\Deprecated(since: '8.6', message: 'as libcurl 8.8.0 removed NTLM_WB support')]
24332435
const CURL_VERSION_NTLM_WB = UNKNOWN;
24342436

24352437
/* Available since 7.24.0 */

ext/curl/curl_arginfo.h

Lines changed: 17 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
--TEST--
2+
CURLAUTH_NTLM_WB and CURL_VERSION_NTLM_WB constants are deprecated
3+
--EXTENSIONS--
4+
curl
5+
--FILE--
6+
<?php
7+
var_dump(CURLAUTH_NTLM_WB);
8+
var_dump(CURL_VERSION_NTLM_WB);
9+
?>
10+
--EXPECTF--
11+
Deprecated: Constant CURLAUTH_NTLM_WB is deprecated since 8.6, as libcurl 8.8.0 removed NTLM_WB support in %s on line %d
12+
int(%d)
13+
14+
Deprecated: Constant CURL_VERSION_NTLM_WB is deprecated since 8.6, as libcurl 8.8.0 removed NTLM_WB support in %s on line %d
15+
int(%d)

0 commit comments

Comments
 (0)