just unwrap

Author: zaaarf

ext/reflection/php_reflection.c

@@ -6724,19 +6724,14 @@ ZEND_METHOD(ReflectionProperty, isReadable)
 handle_magic_get:
 		if (ce->__get) {
 			if (obj && ce->__isset) {
-				if (ce->__isset->common.fn_flags & ZEND_ACC_RETURN_REFERENCE) {
-					//php_error_docref(NULL, E_WARNING, "__isset unexpectedly returned a reference!");
-					zend_error(E_WARNING, "__isset unexpectedly returned a reference!");
-					RETURN_FALSE;
-				}
-
 				uint32_t *guard = zend_get_property_guard(obj, ref->unmangled_name);
 				if (!((*guard) & ZEND_GUARD_PROPERTY_ISSET)) {
 					GC_ADDREF(obj);
 					*guard |= ZEND_GUARD_PROPERTY_ISSET;
 					zval member;
 					ZVAL_STR(&member, ref->unmangled_name);
 					zend_call_known_instance_method_with_1_params(ce->__isset, obj, return_value, &member);
+					zend_unwrap_reference(return_value);
 					*guard &= ~ZEND_GUARD_PROPERTY_ISSET;
 					OBJ_RELEASE(obj);
 					return;

ext/reflection/tests/gh22000.phpt

@@ -33,9 +33,8 @@ test('TestClass');
 --EXPECTF--
 a from global:bool(false)
 b from global:
-Warning: __isset unexpectedly returned a reference! in %s%eext%ereflection%etests%egh22000.php on line %d
+Notice: Only variable references should be returned by reference in /home/zaaarf/dev/irl/c/php/ext/reflection/tests/gh22000.php on line 13
 bool(false)
 c from global:
-Warning: __isset unexpectedly returned a reference! in %s%eext%ereflection%etests%egh22000.php on line %d
-bool(false)
-
+Notice: Only variable references should be returned by reference in /home/zaaarf/dev/irl/c/php/ext/reflection/tests/gh22000.php on line 13
+bool(true)