fix phpstan Call to an undefined method PhpParser\ParserFactory::createForVersion()

Author: Guillaume Chehami

src/FileExtractor/PHPFileExtractor.php

@@ -33,7 +33,7 @@ final class PHPFileExtractor implements FileExtractor
     public function getSourceLocations(SplFileInfo $file, SourceCollection $collection): void
     {
         $path = $file->getRelativePath();
-        $parser = (new ParserFactory())->createForVersion(PhpVersion::fromString('8.1'));
+        $parser = (new ParserFactory())->createForNewestSupportedVersion();
         $traverser = new NodeTraverser();
         foreach ($this->visitors as $v) {
             $v->init($collection, $file);

src/Visitor/Php/Symfony/FormTrait.php

@@ -12,23 +12,103 @@
 namespace Translation\Extractor\Visitor\Php\Symfony;
 
 use PhpParser\Node;
-use PhpParser\Node\Stmt;
+use PhpParser\Node\Stmt\Class_;
 
 trait FormTrait
 {
     private bool $isFormType = false;
+    private array $classMap = [];
+    private array $hierarchyCache = [];
+    private array $symfonyInterface = [
+        'Symfony\Component\Form\FormTypeInterface',
+        'FormTypeInterface',
+    ];
 
-    /**
-     * Check if this node is a form type.
-     */
-    private function isFormType(Node $node): bool
+    protected function registerClass(Class_ $node): void
     {
-        // Check if the class implements FormTypeInterface
-        if ($node instanceof Stmt\Class_) {
-            $this->isFormType = \in_array(
-                'Symfony\Component\Form\FormTypeInterface',
-                array_map(fn ($interface) => $interface->toString(), $node->implements ?? [])
-            );
+        if (!isset($node->name)) {
+            return;
+        }
+
+        $fqcn = $node->name->toString();
+
+        $this->classMap[$fqcn] = [
+            'extends' => $node->extends?->toString(),
+            'implements' => array_map(
+                fn($i) => $i->toString(),
+                $node->implements
+            ),
+        ];
+    }
+
+    protected function resolveHierarchy(
+        string $class,
+        array &$visited = []
+    ): array {
+        if (isset($this->hierarchyCache[$class])) {
+            return $this->hierarchyCache[$class];
+        }
+
+        if (isset($visited[$class])) {
+            return [
+                'extends' => [],
+                'implements' => [],
+            ];
+        }
+
+        $visited[$class] = true;
+
+        $data = $this->classMap[$class] ?? null;
+
+        if (!$data) {
+            return [
+                'extends' => [],
+                'implements' => [],
+            ];
+        }
+
+        $hierarchy = [
+            'extends' => [],
+            'implements' => $data['implements'],
+        ];
+
+        $parent = $data['extends'];
+
+        if ($parent) {
+            $hierarchy['extends'][$parent] =
+                $this->resolveHierarchy($parent, $visited);
+        }
+
+        $this->hierarchyCache[$class] = $hierarchy;
+
+        return $hierarchy;
+    }
+
+    protected function containsInterface(
+        array $hierarchy
+    ): bool {
+
+        foreach ($this->symfonyInterface as $interface) {
+            if (in_array($interface, $hierarchy['implements'], true)) {
+                return true;
+            }
+        }
+
+        foreach ($hierarchy['extends'] as $parentHierarchy) {
+            if ($this->containsInterface($parentHierarchy)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    protected function isFormType(Node $node): bool
+    {
+        if ($node instanceof Class_) {
+            $this->registerClass($node);
+            $hierarchy = $this->resolveHierarchy($node->name->toString());
+            $this->isFormType = $this->containsInterface($hierarchy);
         }
 
         return $this->isFormType;

tests/Resources/Github/Issue_109.php

@@ -3,7 +3,7 @@
 namespace Translation\Extractor\Tests\Resources\Github;
 use Translation\Extractor\Annotation\Ignore;
 
-class MustNotBeIgnoredType
+class MustNotBeIgnoredType implements FormTypeInterface
 {
   public function buildForm(FormBuilderInterface $builder, array $options)
   {

tests/Resources/Github/Issue_111.php

@@ -4,7 +4,7 @@
 
 use Translation\Extractor\Annotation\Ignore;
 
-class Issue111Type
+class Issue111Type implements FormTypeInterface
 {
     public function buildForm(FormBuilderInterface $builder, array $options)
     {

tests/Resources/Github/Issue_62.php

@@ -3,7 +3,7 @@
 use Symfony\Component\Form\AbstractType;
 use Translation\Extractor\Annotation\Ignore;
 
-class EmptyValueType extends AbstractType
+class EmptyValueType implements FormTypeInterface
 {
     public function buildForm(FormBuilderInterface $builder, array $options)
     {

tests/Resources/Github/Issue_78.php

@@ -3,7 +3,7 @@
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\HiddenType;
 
-class EmptyValueType extends AbstractType
+class EmptyValueType implements FormTypeInterface
 {
     public function buildForm(FormBuilderInterface $builder, array $options)
     {

tests/Resources/Github/Issue_80b.php

@@ -2,7 +2,7 @@
 
 use Symfony\Component\Form\AbstractType;
 
-class PlaceholderAsBooleanType extends AbstractType
+class PlaceholderAsBooleanType implements FormTypeInterface
 {
     public function buildForm(FormBuilderInterface $builder, array $options)
     {

tests/Resources/Github/issue_82.php

@@ -2,7 +2,7 @@
 
 namespace Translation\Extractor\Tests\Resources\Github;
 
-class GlobalTranslationDomainType
+class GlobalTranslationDomainType implements FormTypeInterface
 {
     public function buildForm(FormBuilderInterface $builder, array $options)
     {

tests/Resources/Github/issue_96.php

@@ -2,7 +2,7 @@
 
 namespace Translation\Extractor\Tests\Resources\Github;
 
-class GlobalTranslationDomainWithPlaceholderType
+class GlobalTranslationDomainWithPlaceholderType implements FormTypeInterface
 {
     public function buildForm(FormBuilderInterface $builder, array $options)
     {

tests/Resources/Php/Symfony/ChainedChoiceType.php

@@ -2,7 +2,7 @@
 
 namespace Translation\Extractor\Tests\Resources\Php\Symfony;
 
-class ChainedChoiceType
+class ChainedChoiceType implements FormTypeInterface
 {
     public function buildForm(FormBuilderInterface $builder, array $options)
     {