diff --git a/src/Promise.php b/src/Promise.php index 14a8812..49cf84a 100644 --- a/src/Promise.php +++ b/src/Promise.php @@ -109,7 +109,7 @@ private function handleException(GuzzleExceptions\GuzzleException $exception) if ($exception instanceof GuzzleExceptions\RequestException) { // Make sure we have a response for the HttpException - if ($exception->hasResponse()) { + if ($exception instanceof GuzzleExceptions\ResponseException) { return new HttplugException\HttpException( $exception->getMessage(), $exception->getRequest(), diff --git a/tests/PromiseExceptionTest.php b/tests/PromiseExceptionTest.php index a80083e..2285bf6 100644 --- a/tests/PromiseExceptionTest.php +++ b/tests/PromiseExceptionTest.php @@ -45,12 +45,12 @@ public static function exceptionThatIsThrownForGuzzleExceptionProvider(): array return [ [$request, new GuzzleExceptions\ConnectException('foo', $request), NetworkException::class], - [$request, new GuzzleExceptions\TooManyRedirectsException('foo', $request), RequestException::class], - [$request, new GuzzleExceptions\RequestException('foo', $request, $response), HttpException::class], + [$request, new GuzzleExceptions\TooManyRedirectsException('foo', $request, $response), RequestException::class], + [$request, new GuzzleExceptions\ResponseException('foo', $request, $response), HttpException::class], [$request, new GuzzleExceptions\BadResponseException('foo', $request, $response), HttpException::class], [$request, new GuzzleExceptions\ClientException('foo', $request, $response), HttpException::class], [$request, new GuzzleExceptions\ServerException('foo', $request, $response), HttpException::class], - [$request, new GuzzleExceptions\TransferException('foo'), TransferException::class], + [$request, new GuzzleExceptions\TransferException('foo', $request), TransferException::class], // check cases without response [$request, new GuzzleExceptions\RequestException('foo', $request), RequestException::class], [$request, new GuzzleExceptions\BadResponseException('foo', $request, $response), RequestException::class],