feat: add Connect-specific scripts for 8 scanners#148
Open
kbaker827 wants to merge 2 commits into
Open
Conversation
Each Connect-* script addresses the reason the original was marked as not compatible with PDQ Connect: - Connect-Get Available Windows Updates: inlines PSWindowsUpdate module install and fixes WSUS service flag (same fix as pdqcom#109) - Connect-Get Windows Update History: inlines PSWindowsUpdate install and replaces Scanner.log row-limit with a -Limit parameter (default 200) - Connect-Windows Update Last Installed: inlines PSWindowsUpdate install - Connect-Dell BIOS Information: inlines DellBIOSProvider install - Connect-File Hash: makes -Path mandatory (SYSTEM profile is not a useful default when running in Connect) - Connect-Get CDP Neighbor Data: installs PSDiscoveryProtocol from PSGallery instead of loading from a local .psm1 file - Connect-Hosts File: replaces ConvertFrom-String (unavailable in PowerShell 7+) with direct whitespace splitting - Connect-Certificates: hardcodes a concise set of properties and defaults to LocalMachine to avoid oversized output Closes pdqcom#122 pdqcom#123 pdqcom#124 pdqcom#125 pdqcom#126 pdqcom#130 pdqcom#135 pdqcom#138
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Connect-<Name>.ps1scripts for 8 scanners that couldn't work in PDQ Connect as-is, and updates each scanner's README. The common pattern is inlining the sharedInstall and Import Module.ps1helper since relative path.\references don't work in Connect's execution context.Install and Import Module.ps1; also wrong WSUS service flag-WindowsUpdate→ no flag for WSUS (same fix as #109)Scanner.log(Inventory-only file)-Limitparameter (default 200)Install and Import Module.ps1Install and Import Module.ps1$env:userprofileresolves to SYSTEM profile when running as SYSTEM-PathmandatoryImport-Module '.\PSDiscoveryProtocol.psm1'loads a local bundled filePSDiscoveryProtocolfrom PSGalleryConvertFrom-Stringis not available in PowerShell 7+-split '\s+'-Property *produces very large outputLocalMachineonlyTest plan
Connect-*.ps1into a PDQ Connect Run PowerShell action and confirm outputConnect-Get Available Windows Updates.ps1 -WSUSreturns only WSUS-approved updatesConnect-Get Windows Update History.ps1 -Limit 50returns ≤50 rowsConnect-Hosts File.ps1works on both PowerShell 5.1 and 7+Closes #122 #123 #124 #125 #126 #130 #135 #138