fix: add quser fallback for currently logged-on users#145
Open
kbaker827 wants to merge 2 commits into
Open
Conversation
On machines where only logon types 3/5 appear in the Security event log (remote sessions, VDI, etc.), the event-log scan returns no results. Fall back to quser to capture the currently logged-on user in those cases. Also guard against empty account names and wrap quser in a try/catch so any errors are handled cleanly rather than propagating to the scanner. Closes pdqcom#110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quserfallback that runs after the event log scan and captures the currently logged-on user if they weren't already found$AccountName -ne ""check)quserin a try/catch and checks$LASTEXITCODEto handle machines with no logged-on user cleanly$ResultsArrayList so the event log scan and quser results are emitted togetherRoot cause
On many machines (especially those accessed primarily via remote/network sessions), interactive logon events with types 2/10/11 are absent from the Security log. The scanner only looked at those types, so it returned nothing even though a user was actively logged on.
Test plan
LogonType = "Current User"Closes #110