add locking back

takeyourhatoff · takeyourhatoff · commit 6ad0d0b73de4 · 2024-10-02T21:07:06.000+01:00
diff --git a/datamodel/high/base/schema_proxy.go b/datamodel/high/base/schema_proxy.go
@@ -168,10 +168,13 @@ func (sp *SchemaProxy) BuildTempSchema() (*Schema, error) {
 	if sp == nil {
 		return nil, nil
 	}
+	sp.lock.Lock()
 	s := sp.schema.Value.TempSchema()
 	if s == nil {
+		defer sp.lock.Unlock()
 		return nil, sp.schema.Value.GetBuildError()
 	}
+	sp.lock.Unlock()
 	sch := NewSchema(s)
 	sch.ParentProxy = sp
 	return sch, nil

Original file line number	Diff line number	Diff line change
`@@ -168,10 +168,13 @@ func (sp SchemaProxy) BuildTempSchema() (Schema, error) {`
`168`	`168`	`if sp == nil {`
`169`	`169`	`return nil, nil`
`170`	`170`	`}`
	`171`	`+ sp.lock.Lock()`
`171`	`172`	`s := sp.schema.Value.TempSchema()`
`172`	`173`	`if s == nil {`
	`174`	`+ defer sp.lock.Unlock()`
`173`	`175`	`return nil, sp.schema.Value.GetBuildError()`
`174`	`176`	`}`
	`177`	`+ sp.lock.Unlock()`
`175`	`178`	`sch := NewSchema(s)`
`176`	`179`	`sch.ParentProxy = sp`
`177`	`180`	`return sch, nil`