Skip to content

Commit e4ee748

Browse files
committed
Attach null stdio to pass nvm-windows check
https://github.com/coreybutler/nvm-windows/blob/6284f0ec44040764dc269144a3433664bf089646/src/nvm.go#L188 https://github.com/coreybutler/nvm-windows/blob/6284f0ec44040764dc269144a3433664bf089646/src/nvm.go#L73 In nvm-windows, if stdout isn't a character device, it shows an error dialog and waits for user input before terminating Attach /dev/null to make sure that nvm-windows doesn't need intervention (https://nodejs.org/api/child_process.html#optionsstdio)
1 parent 46857d7 commit e4ee748

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<a name="check-node-version"></a>
22
# check-node-version
33
[![NPM version](http://img.shields.io/npm/v/check-node-version.svg?style=flat-square)](https://www.npmjs.org/package/check-node-version)
4-
[![AppVeyor build status](https://img.shields.io/appveyor/ci/parshap/check-node-version/master.svg?style=flat-square)](https://ci.appveyor.com/project/parshap/check-node-version/branch/master)
5-
[![Travis build status](http://img.shields.io/travis/parshap/check-node-version/master.svg?style=flat-square)](https://travis-ci.org/parshap/check-node-version)
4+
[![AppVeyor build status](https://img.shields.io/appveyor/ci/timgblack/check-node-version/be-a-terminal-for-nvm-windows.svg?style=flat-square)](https://ci.appveyor.com/project/timgblack/check-node-version/branch/be-a-terminal-for-nvm-windows)
5+
[![Travis build status](http://img.shields.io/travis/timgblack/check-node-version/be-a-terminal-for-nvm-windows.svg?style=flat-square)](https://travis-ci.org/timgblack/check-node-version)
66

77
Check installed versions of `node`, `npm`, `npx`, `yarn`, and `pnpm`.
88

tools.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ function hasNvm() {
4242
// check for existance of nvm
4343
execSync(
4444
'nvm',
45-
{ stdio:[] } // don't care about output
45+
{ stdio: 'ignore' } // don't care about output
4646
);
4747
} catch (e) {
4848
// no nvm,

0 commit comments

Comments
 (0)