Add type annotations for instance attributes in click.core

[jorenham]

Here's the last one in the type coverage PR series (+3.71%). Because this, together with #3422, #3451, #3453, #3454, and #3455, will bring click to 100% type coverage 🎉.

[jorenham]

The failing Mac CI job seems unrelated (race condition?)

[davidism]

Please combine all these PRs into one PR with multiple commits. That will make it much easier to review and merge.

[jorenham]

Please combine all these PRs into one PR with multiple commits. That will make it much easier to review and merge.

Haha I've often been asked to do the exact opposite by maintainers of other projects. But sure, I don't mind combining them :)

[kdeldycke]

Haha I've often been asked to do the exact opposite by maintainers of other projects. But sure, I don't mind combining them :)

Also can you rebase them on top of stable. If typing improvements do not change the API or behavior, then I would consider them as I consider improved tests and bug fixes: OK for bug fix releases.

[kdeldycke]

Please combine all these PRs into one PR with multiple commits. That will make it much easier to review and merge.

Sorry for the aggressive review requests on the other PRs from @jorenham . I just stumble on your comment on that last one from the batch. 🙇

[kdeldycke]

The failing Mac CI job seems unrelated (race condition?)

Unrelated. But you can make it disappear by rebasing on stable branch.

[kdeldycke]

Please combine all these PRs into one PR with multiple commits. That will make it much easier to review and merge.

Rethinking of this, maybe @jorenham is onto something by providing small, targeted typing changes: they increase the change of being merged for bug fix releases, as some tightening attempts stay self-contained while others requires some code changes. I propose to work on the individual splatted PRs @jorenham proposed as @AndreasBackx started to make a review on them.