Skip to content

Commit 465f302

Browse files
Adding conditional Log Detective variables to configuration templates (#687)
Adding conditional Log Detective variables to configuration templates I've used the same approach as utilized by other secrets. Both URL and token will be stored in bitwarden and rendered into template only if the URL is present. Log Detective interface server will always require authentication. Therefore, any configuration when URL is set, but the token is missing, is not viable. Since removing the fields from configuration can be accomplished by just renaming, or removing, the variables in bitwarden, the fields were added to both prod and stage configuration templates. RELEASE NOTES BEGIN Log Detective URL and token are now conditional part of the service configuration. RELEASE NOTES END Reviewed-by: Nikola Forró Reviewed-by: Jiří Podivín
2 parents 929e5c7 + afb5b4f commit 465f302

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

secrets/packit/prod/packit-service.yaml.j2

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2375,3 +2375,8 @@ enabled_projects_for_fedora_ci:
23752375
- https://src.fedoraproject.org/rpms/yt-dlp
23762376
- https://src.fedoraproject.org/rpms/zathura-pdf-mupdf
23772377
- https://src.fedoraproject.org/rpms/zeal
2378+
2379+
# Log Detective interface server URL and token
2380+
logdetective_enabled: false
2381+
logdetective_url: {{ vault.logdetective.url }}
2382+
logdetective_token: {{ vault.logdetective.token }}

secrets/packit/stg/packit-service.yaml.j2

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,3 +154,8 @@ enabled_projects_for_fedora_ci:
154154
- https://src.fedoraproject.org/rpms/python-scikit-build-core
155155
- https://src.fedoraproject.org/rpms/python-specfile
156156
- https://src.fedoraproject.org/rpms/spglib
157+
158+
# Log Detective interface server URL and token
159+
logdetective_enabled: false
160+
logdetective_url: {{ vault.logdetective.url }}
161+
logdetective_token: {{ vault.logdetective.token }}

0 commit comments

Comments
 (0)