Skip to content

Commit 4477096

Browse files
committed
er
1 parent 10b9f33 commit 4477096

37 files changed

Lines changed: 39 additions & 336 deletions

TODO.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
Major Architectual
22
Hooks
33
Namespaces/Extensions
4-
Lifecycle
4+
Lifetime
5+
6+
Cleanup
7+
Services (incl .provide)
58

69

710

modules/packed/src/main/java/app/packed/Framework.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ public static Framework.Version version() {
5454
// Typically called from a static init of the class
5555

5656
// Tror vi skal have dem mere specifikke fx Bean.openClass
57+
// Or maybe BeanOpener
5758
@Deprecated
5859
public static void openClassToFramework(MethodHandles.Lookup lookup) {
5960
openClassToFramework(lookup, lookup.lookupClass());

modules/packed/src/main/java/app/packed/bean/BeanConfiguration.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import java.util.stream.Stream;
1010

1111
import app.packed.binding.Key;
12-
import app.packed.build.action.BuildActionable;
1312
import app.packed.component.ComponentConfiguration;
1413
import app.packed.component.ComponentRealm;
1514
import app.packed.context.Context;
@@ -47,7 +46,6 @@ public BeanConfiguration(BeanHandle<?> handle) {
4746
* @throws UnsupportedOperationException
4847
* if called on a bean with void bean class
4948
*/
50-
@BuildActionable("bean.allowMultiClass")
5149
public BeanConfiguration<T> allowMultiClass() {
5250
checkIsConfigurable();
5351
handle.allowMultiClass();
@@ -102,7 +100,6 @@ public final BeanKind beanLifetime() {
102100
* @see CodeGenerated
103101
* @see BindableVariable#bindGeneratedConstant(Supplier)
104102
*/
105-
@BuildActionable("bean.addCodeGenerator")
106103
public <K> void bindComputedConstant(Class<K> key, Supplier<? extends K> supplier) {
107104
checkIsConfigurable();
108105
bindComputedConstant(Key.of(key), supplier);
@@ -134,7 +131,6 @@ public <K> void bindComputedConstant(Class<K> key, Supplier<? extends K> supplie
134131
* @see ComputedConstant
135132
* @see BindableVariable#bindGeneratedConstant(Supplier)
136133
*/
137-
@BuildActionable("bean.addCodeGenerator")
138134
// ComputedService instead??? buildConstant??? IDK
139135
// Hmm, bliver vi noedt til at sige noget om hvornaar den bliver kaldt???
140136
// Den bliver jo tidligst kaldt som en del af build processen
@@ -235,7 +231,6 @@ public final boolean isInSameContainer(BeanConfiguration<?> other) {
235231
* if there is another bean with the same name in the container. Or if the container has a child container
236232
* with the same name.
237233
*/
238-
@BuildActionable("bean.named")
239234
public BeanConfiguration<?> named(String name) {
240235
checkIsConfigurable();
241236
handle.named(name);
@@ -310,7 +305,6 @@ protected Set<Key<?>> requestedServiceKeys() {
310305

311306
/** {@inheritDoc} */
312307
@Override
313-
@BuildActionable("component.addTags") // Hmm or bean.addTags
314308
public BeanConfiguration<T> tag(String... tags) {
315309
checkIsConfigurable();
316310
handle.componentTag(tags);

modules/packed/src/main/java/app/packed/bean/BeanMirror.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import app.packed.bean.BeanTrigger.AutoServiceInheritable;
1717
import app.packed.binding.Key;
1818
import app.packed.build.Mirror;
19-
import app.packed.build.action.BuildActionMirror;
2019
import app.packed.component.ComponentMirror;
2120
import app.packed.component.ComponentPath;
2221
import app.packed.component.ComponentRealm;
@@ -149,10 +148,6 @@ public final int hashCode() {
149148
return handle.bean.hashCode();
150149
}
151150

152-
BuildActionMirror installationAction() {
153-
throw new UnsupportedOperationException();
154-
}
155-
156151
/** {@return the extension that installed the bean, typically BaseExtension} */
157152
public final Class<? extends Extension<?>> installedByExtension() {
158153
return handle.bean.installedBy.extensionType;

modules/packed/src/main/java/app/packed/bean/sandbox/BeanTriggerType.java renamed to modules/packed/src/main/java/app/packed/bean/sandbox/BeanTriggerKind.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@
2424
// Hmm, maaske bare annoteringstypen????
2525

2626
// Maybe skip Inheritable... It is only source
27-
enum BeanTriggerType {
28-
ANNOTATED_CLASS, ANNOTATED_METHOD, ANNOTATED_FIELD, ANNOTATED_VARIABLE, CONTEXTUAL_SERVICE, INHERITABLE_CONTEXTUAL_SERVICE
27+
enum BeanTriggerKind {
28+
ANNOTATED_CLASS, ANNOTATED_METHOD, ANNOTATED_FIELD, ANNOTATED_VARIABLE, AUTO_SERVICE, INHERITABLE_CONTEXTUAL_SERVICE
2929
}

modules/packed/src/main/java/app/packed/bean/sandbox/NewIntrospector.java

Lines changed: 0 additions & 167 deletions
This file was deleted.

modules/packed/src/main/java/app/packed/component/ComponentConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public final ComponentPath componentPath() {
6262
/** {@inheritDoc} */
6363
@Override
6464
public final boolean equals(Object obj) {
65-
return obj instanceof ComponentConfiguration cc && handle().equals(cc.handle());
65+
return obj instanceof ComponentConfiguration cc && handle() == cc.handle();
6666
}
6767

6868
/** {@return the underlying handle of this component} */

modules/packed/src/main/java/app/packed/container/ContainerConfiguration.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import java.util.stream.Stream;
88

99
import app.packed.bean.BeanConfiguration;
10-
import app.packed.build.action.BuildActionable;
1110
import app.packed.component.ComponentConfiguration;
1211
import app.packed.extension.Extension;
1312
import internal.app.packed.extension.ExtensionSetup;
@@ -46,7 +45,6 @@ public final <T extends BeanConfiguration<?>> Stream<T> beans(Class<? extends Be
4645

4746
/** {@inheritDoc} */
4847
@Override
49-
@BuildActionable("container.addTags")
5048
public ComponentConfiguration tag(String... tags) {
5149
checkIsConfigurable();
5250
handle.componentTag(tags);
@@ -113,7 +111,6 @@ public final boolean isExtensionUsed(Class<? extends Extension<?>> extensionType
113111
* characters and '_', '-' or '.'
114112
* @see Wirelet#named(String)
115113
*/
116-
@BuildActionable("container.named")
117114
public ContainerConfiguration named(String name) {
118115
checkIsConfigurable();
119116
handle.container.named(name);
@@ -177,7 +174,6 @@ public String toString() {
177174
* @see #extensionsTypes()
178175
* @see BaseAssembly#use(Class)
179176
*/
180-
@BuildActionable("container.installExtension")
181177
public final <E extends Extension<?>> E use(Class<E> extensionClass) {
182178
ExtensionSetup extension = handle.container.useExtension(extensionClass, null);
183179
return extensionClass.cast(extension.instance());

modules/packed/src/main/java/app/packed/container/ContainerInstaller.java

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
package app.packed.container;
1717

1818
import app.packed.assembly.Assembly;
19-
import app.packed.binding.Key;
2019
import internal.app.packed.container.PackedContainerInstaller;
2120

2221
/**
@@ -113,25 +112,6 @@ public sealed interface ContainerInstaller<H extends ContainerHandle<?>> permits
113112
*/
114113
ContainerInstaller<H> named(String name);
115114

116-
/**
117-
* Provides constants per Carrier Instance for this particular container builder
118-
*
119-
* @param <T>
120-
* @param key
121-
* @param arg
122-
* @return
123-
*
124-
* @see ExtensionLink#ofConstant(Class, Object)
125-
*/
126-
default <T> ContainerInstaller<H> provideGuestConstant(Class<T> key, T constant) {
127-
return provideGuestConstant(Key.of(key), constant);
128-
}
129-
130-
/**
131-
* @see FromLifetimeChannel
132-
*/
133-
<T> ContainerInstaller<H> provideGuestConstant(Key<T> key, T constant);
134-
135115
/**
136116
* Sets the value of the specified container local for the container being built.
137117
*

0 commit comments

Comments
 (0)