chore(docsfilter): handle errors

Author: forshev

docsfilter/docs_filter.go

@@ -167,7 +167,11 @@ func (df *DocsFilter) RefreshFrac(fraction frac.Fraction) {
 		util.MustWriteFileAtomic(queueFilePath, []byte{}, tmpExt)
 
 		filter.processWg.Add(1)
-		go df.processFrac(fraction, filter, true) // nolint:errcheck // TODO: in progress
+		go func() {
+			if err := df.processFrac(fraction, filter, false); err != nil {
+				panic(fmt.Errorf("docs filter refresh frac err: %s", err))
+			}
+		}()
 	}
 }
 
@@ -281,7 +285,11 @@ func (df *DocsFilter) processFilter(filter *Filter, fracs fracmanager.List) {
 	processFracInQueue := func(name string) error {
 		f := fracsByName[fracNameFromFilePath(name)]
 		filter.processWg.Add(1)
-		go df.processFrac(f, filter, false) // nolint:errcheck // TODO: in progress
+		go func() {
+			if err := df.processFrac(f, filter, false); err != nil {
+				panic(fmt.Errorf("docs filter process frac err: %s", err))
+			}
+		}()
 
 		return nil
 	}
@@ -321,7 +329,12 @@ func (df *DocsFilter) processFrac(f frac.Fraction, filter *Filter, refresh bool)
 		util.RemoveFile(tmpFilePath)
 		return nil
 	}
-	// TODO: don't read lids twice: f.Search() and f.FindLIDs()
+
+	// TODO: here we doing part of the work twice:
+	// first time we find LIDs inside f.Search() and then find IDs by these LIDs.
+	// Then we again find LIDs by earlier found IDs in f.FindLIDs().
+	// We did it like this because otherwise we had to do serious f.Search() rewrite.
+	// For now we're ok with some performance penalty.
 	lids, err := f.FindLIDs(df.ctx, qpr.IDs.IDs())
 	if err != nil {
 		return err

frac/active_index.go

@@ -263,7 +263,7 @@ func (di *activeFetchIndex) GetBlocksOffsets(num uint32) uint64 {
 	return di.blocksOffsets[num]
 }
 
-func (di *activeFetchIndex) GetDocPos(ids []seq.ID) []seq.DocPos {
+func (di *activeFetchIndex) GetDocPos(ids []seq.ID) ([]seq.DocPos, error) {
 	// TODO: don't read tombstones twice for search
 	// TODO: optimize all these maps creation and slices traversal
 
@@ -272,9 +272,13 @@ func (di *activeFetchIndex) GetDocPos(ids []seq.ID) []seq.DocPos {
 		docsPos[i] = di.docsPositions.GetSync(id)
 	}
 
-	tombstoneLIDs, _ := di.docsFilter.GetFilteredLIDsByFrac(di.fracName) // TODO: handle the error
+	tombstoneLIDs, err := di.docsFilter.GetFilteredLIDsByFrac(di.fracName)
+	if err != nil {
+		return nil, err
+	}
+
 	if len(tombstoneLIDs) == 0 {
-		return docsPos
+		return docsPos, nil
 	}
 
 	allLids := make([]seq.LID, len(ids))
@@ -295,7 +299,7 @@ func (di *activeFetchIndex) GetDocPos(ids []seq.ID) []seq.DocPos {
 		}
 	}
 
-	return docsPos
+	return docsPos, nil
 }
 
 func (di *activeFetchIndex) ReadDocs(blockOffset uint64, docOffsets []uint64) ([][]byte, error) {

frac/fraction.go

@@ -21,7 +21,7 @@ type Fraction interface {
 	Contains(mid seq.MID) bool
 	Fetch(context.Context, []seq.ID) ([][]byte, error)
 	Search(context.Context, processor.SearchParams) (*seq.QPR, error)
-	FindLIDs(context.Context, []seq.ID) ([]seq.LID, error) // TODO: ???
+	FindLIDs(context.Context, []seq.ID) ([]seq.LID, error)
 }
 
 var (

frac/processor/fetch.go

@@ -7,13 +7,16 @@ import (
 
 type fetchIndex interface {
 	GetBlocksOffsets(uint32) uint64
-	GetDocPos([]seq.ID) []seq.DocPos
+	GetDocPos([]seq.ID) ([]seq.DocPos, error)
 	ReadDocs(blockOffset uint64, docOffsets []uint64) ([][]byte, error)
 }
 
 func IndexFetch(ids []seq.ID, sw *stopwatch.Stopwatch, fetchIndex fetchIndex, res [][]byte) error {
 	m := sw.Start("get_docs_pos")
-	docsPos := fetchIndex.GetDocPos(ids)
+	docsPos, err := fetchIndex.GetDocPos(ids)
+	if err != nil {
+		return err
+	}
 	blocks, offsets, index := seq.GroupDocsOffsets(docsPos)
 	m.Stop()
 

frac/sealed_index.go

@@ -279,15 +279,18 @@ func (fi *sealedFetchIndex) GetBlocksOffsets(num uint32) uint64 {
 	return fi.blocksOffsets[num]
 }
 
-func (fi *sealedFetchIndex) GetDocPos(ids []seq.ID) []seq.DocPos {
+func (fi *sealedFetchIndex) GetDocPos(ids []seq.ID) ([]seq.DocPos, error) {
 	// TODO: don't read tombstones twice for search
 	// TODO: optimize all these maps creation and slices traversal
 
 	allLids := fi.findLIDs(ids)
-	tombstoneLIDs, _ := fi.docsFilter.GetFilteredLIDsByFrac(fi.fracName) // TODO: handle the error
+	tombstoneLIDs, err := fi.docsFilter.GetFilteredLIDsByFrac(fi.fracName)
+	if err != nil {
+		return nil, err
+	}
 
 	if len(tombstoneLIDs) == 0 {
-		return fi.getDocPosByLIDs(allLids)
+		return fi.getDocPosByLIDs(allLids), nil
 	}
 
 	filtersLIDsMap := make(map[seq.LID]struct{}, len(tombstoneLIDs))
@@ -301,7 +304,7 @@ func (fi *sealedFetchIndex) GetDocPos(ids []seq.ID) []seq.DocPos {
 		}
 	}
 
-	return fi.getDocPosByLIDs(allLids)
+	return fi.getDocPosByLIDs(allLids), nil
 }
 
 func (fi *sealedFetchIndex) ReadDocs(blockOffset uint64, docOffsets []uint64) ([][]byte, error) {