Skip to content

Commit 731ff8c

Browse files
Adjust UART fifo backpressure thresholds-
We really want to assert backpressure *before* we're full
1 parent ec01ae6 commit 731ff8c

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

hdl/projects/cosmo_seq/sp5_uart_subsystem/sp5_uart_subsystem.vhd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ begin
133133
parity => false,
134134
use_hw_handshake => true,
135135
fifo_depth => CONSOLE_FIFO_DEPTH,
136-
full_threshold => CONSOLE_FIFO_DEPTH
136+
full_threshold => CONSOLE_FIFO_ALMOST_FULL
137137
)
138138
port map(
139139
clk => clk,
@@ -180,7 +180,7 @@ begin
180180
parity => false,
181181
use_hw_handshake => true,
182182
fifo_depth => IPCC_FIFO_DEPTH,
183-
full_threshold => IPCC_FIFO_DEPTH
183+
full_threshold => IPCC_FIFO_ALMOST_FULL
184184
)
185185
port map(
186186
clk => clk,

hdl/projects/cosmo_seq/sp5_uart_subsystem/sp5_uart_subsystem_pkg.vhd

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ use work.calc_pkg.all;
1313
package sp5_uart_subsystem_pkg is
1414

1515
constant CONSOLE_FIFO_DEPTH : integer := 256; -- FIFO depth for UARTs
16-
constant IPCC_FIFO_DEPTH : integer := 16; -- FIFO depth for IPCC UART
16+
constant CONSOLE_FIFO_ALMOST_FULL : integer := CONSOLE_FIFO_DEPTH - 8; -- Threshold for "almost full" status signal
17+
constant IPCC_FIFO_DEPTH : integer := 32; -- FIFO depth for IPCC UART
18+
constant IPCC_FIFO_ALMOST_FULL : integer := IPCC_FIFO_DEPTH - 8; -- Threshold for "almost full" status signal
1719

1820
-- To the debug interface
1921
type console_uart_dbg_t is record

0 commit comments

Comments
 (0)