"Project to be deleted contains" message only lists one item

[paudmir]

I was trying to delete an instance, and was removing each item (e.g. Disks, Floating IP, etc).
The last warning I got was that I should delete the project image, but I actually have 3 of them.

Ideally, it would be good to let the user know about the other images as well. Maybe the first 3? Maybe print the list but set a limit in characters?

images_delete_project.mp4

[david-crespo]

I'm not sure there's a better way here, at least not in the error message itself. The SQL query that detects children is designed to stop at the first thing it finds for efficiency reasons. We could have it say "contains an image" or "contains images". It might be cute to fetch 2 instead of 1, that way we could tell whether to pluralize it, and maybe we'd only say the name of it if there is exactly one.

omicron/nexus/db-queries/src/db/datastore/project.rs

Lines 81 to 83 in 8677bbb

	return Err(Error::invalid_request(
	format!("project to be deleted contains {article} {object}: {label}")
	));

I think of the real problem here as "I want to delete the whole project in one go", which is #4674.

[paudmir]

@david-crespo Yups, that's really the bigger thing to tackle. I would envision that as the reverse of the flow we see then uploading a new image, where you would see each step being executed (if #4674 does happen).