test: create new tests for OCUserRepositoryTest and OCRemoteUserDataSourceTest

Author: joragua

owncloudData/src/test/java/com/owncloud/android/data/user/datasources/implementation/OCRemoteUserDataSourceTest.kt

@@ -2,7 +2,9 @@
  * ownCloud Android client application
  *
  * @author Abel García de Prada
- * Copyright (C) 2020 ownCloud GmbH.
+ * @author Jorge Aguado Recio
+ *
+ * Copyright (C) 2025 ownCloud GmbH.
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2,
@@ -27,6 +29,7 @@ import com.owncloud.android.lib.resources.users.RemoteUserInfo
 import com.owncloud.android.lib.resources.users.services.implementation.OCUserService
 import com.owncloud.android.testutil.OC_ACCOUNT_NAME
 import com.owncloud.android.testutil.OC_USER_AVATAR
+import com.owncloud.android.testutil.OC_USER_ID
 import com.owncloud.android.testutil.OC_USER_INFO
 import com.owncloud.android.testutil.OC_USER_QUOTA
 import com.owncloud.android.utils.createRemoteOperationResultMock
@@ -123,5 +126,21 @@ class OCRemoteUserDataSourceTest {
 
         verify(exactly = 1) { ocUserService.getUserAvatar(avatarDimension) }
     }
+
+    @Test
+    fun `getUserId returns String containing the user id`() {
+        val getUserIdResult: RemoteOperationResult<String> = createRemoteOperationResultMock(data = OC_USER_ID, isSuccess = true)
+
+        every {
+            ocUserService.getUserId()
+        } returns getUserIdResult
+
+        val userId = ocRemoteUserDataSource.getUserId(OC_ACCOUNT_NAME)
+        assertEquals(OC_USER_ID, userId)
+
+        verify(exactly = 1) {
+            ocUserService.getUserId()
+        }
+    }
 }
 

owncloudData/src/test/java/com/owncloud/android/data/user/repository/OCUserRepositoryTest.kt

@@ -21,10 +21,12 @@
 
 package com.owncloud.android.data.user.repository
 
+import com.owncloud.android.data.authentication.datasources.LocalAuthenticationDataSource
 import com.owncloud.android.data.user.datasources.LocalUserDataSource
 import com.owncloud.android.data.user.datasources.RemoteUserDataSource
 import com.owncloud.android.testutil.OC_ACCOUNT_NAME
 import com.owncloud.android.testutil.OC_USER_AVATAR
+import com.owncloud.android.testutil.OC_USER_ID
 import com.owncloud.android.testutil.OC_USER_INFO
 import com.owncloud.android.testutil.OC_USER_QUOTA
 import io.mockk.every
@@ -40,7 +42,8 @@ import org.junit.Test
 class OCUserRepositoryTest {
     private val remoteUserDataSource = mockk<RemoteUserDataSource>()
     private val localUserDataSource = mockk<LocalUserDataSource>(relaxUnitFun = true)
-    private val ocUserRepository = OCUserRepository(localUserDataSource, remoteUserDataSource)
+    private val localAuthenticationDataSource = mockk<LocalAuthenticationDataSource>(relaxUnitFun = true)
+    private val ocUserRepository = OCUserRepository(localUserDataSource, localAuthenticationDataSource, remoteUserDataSource)
 
     @Test
     fun `getUserInfo returns an UserInfo`() {
@@ -155,4 +158,38 @@ class OCUserRepositoryTest {
         }
     }
 
+    @Test
+    fun `getUserId returns a String with the user id when it exists in Account Manager`() {
+        every {
+            localAuthenticationDataSource.getUserId(OC_ACCOUNT_NAME)
+        } returns OC_USER_ID
+
+        val accountId = ocUserRepository.getUserId(OC_ACCOUNT_NAME)
+        assertEquals(OC_USER_ID, accountId)
+
+        verify(exactly = 1) {
+            localAuthenticationDataSource.getUserId(OC_ACCOUNT_NAME)
+        }
+    }
+
+    @Test
+    fun `getUserId returns a String with the user id when it does not exist in Account Manager`() {
+        every {
+            localAuthenticationDataSource.getUserId(OC_ACCOUNT_NAME)
+        } returns null
+
+        every {
+            remoteUserDataSource.getUserId(OC_ACCOUNT_NAME)
+        } returns OC_USER_ID
+
+        val userId = ocUserRepository.getUserId(OC_ACCOUNT_NAME)
+        assertEquals(OC_USER_ID, userId)
+
+        verify(exactly = 1) {
+            localAuthenticationDataSource.getUserId(OC_ACCOUNT_NAME)
+            remoteUserDataSource.getUserId(OC_ACCOUNT_NAME)
+            localAuthenticationDataSource.saveIdForAccount(OC_ACCOUNT_NAME, OC_USER_ID)
+        }
+    }
+
 }

owncloudTestUtil/src/main/java/com/owncloud/android/testutil/OCUser.kt

@@ -65,3 +65,5 @@ val OC_USER_AVATAR = UserAvatar(
     eTag = "edcdc7d39dc218d197c269c8f75ab0f4",
     mimeType = "image/png"
 )
+
+const val OC_USER_ID = "us3r1d"