Skip to content

Prototype 2: Evaluating alternatives to YAJL for JSON processing #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Easton97-Jens wants to merge 13 commits into
base: v3/master
Choose a base branch
from

Merge branch 'owasp-modsecurity:v3/master' into v3/master-json2

3ec86cf
Select commit
Loading
Failed to load commit list.
Refresh
Open

Prototype 2: Evaluating alternatives to YAJL for JSON processing #3540

Merge branch 'owasp-modsecurity:v3/master' into v3/master-json2
3ec86cf
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 13, 2026 in 4m 3s

Quality Gate passed

Issues
42 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 235 in test/regression/regression_test.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 23 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ2DVDgODPiZK5yPV1-J&open=AZ2DVDgODPiZK5yPV1-J&pullRequest=3540

Check failure on line 412 in src/request_body_processor/json_backend_jsoncons.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 43 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ2BthMEO-njQfcv_7WJ&open=AZ2BthMEO-njQfcv_7WJ&pullRequest=3540

Check warning on line 262 in test/common/json.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "error" is "std::string *". 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ190QIVSTzC4JOHOn-m&open=AZ190QIVSTzC4JOHOn-m&pullRequest=3540

Check warning on line 183 in src/utils/json_writer.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::byte" for byte-oriented data manipulation. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ190QA8STzC4JOHOn9n&open=AZ190QA8STzC4JOHOn9n&pullRequest=3540

Check warning on line 73 in src/operators/validate_byte_range.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::byte" for byte-oriented data manipulation. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ190QEMSTzC4JOHOn9q&open=AZ190QEMSTzC4JOHOn9q&pullRequest=3540

Check warning on line 188 in src/request_body_processor/json_backend_jsoncons.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

4 enumeration values not handled in switch: 'int64_value', 'uint64_value', 'half_value'... 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ190QFsSTzC4JOHOn9u&open=AZ190QFsSTzC4JOHOn9u&pullRequest=3540

Check failure on line 89 in test/common/modsecurity_test.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ190QI2STzC4JOHOn-s&open=AZ190QI2STzC4JOHOn-s&pullRequest=3540

Check warning on line 156 in src/operators/validate_byte_range.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::byte" for byte-oriented data manipulation. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ2CBI6Kkud7vHWq0tqj&open=AZ2CBI6Kkud7vHWq0tqj&pullRequest=3540

Check failure on line 374 in src/request_body_processor/json_backend_jsoncons.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ190QFsSTzC4JOHOn91&open=AZ190QFsSTzC4JOHOn91&pullRequest=3540

Check warning on line 401 in src/request_body_processor/json_backend_simdjson.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ2CwcnoK0fgB4uOpVK4&open=AZ2CwcnoK0fgB4uOpVK4&pullRequest=3540

Check warning on line 232 in src/modsecurity.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this loop so that it is less error-prone. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ190QIESTzC4JOHOn-d&open=AZ190QIESTzC4JOHOn-d&pullRequest=3540

Check failure on line 365 in src/request_body_processor/json_backend_jsoncons.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ190QFsSTzC4JOHOn90&open=AZ190QFsSTzC4JOHOn90&pullRequest=3540

Check warning on line 321 in test/benchmark/json_benchmark.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this const reference to "std::string" by a "std::string_view". 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ1-doCWXISY38E6TxpK&open=AZ1-doCWXISY38E6TxpK&pullRequest=3540

Check warning on line 568 in src/request_body_processor/json_backend_jsoncons.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "sync_detail" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ2H7l3jym_e-6l8FQmi&open=AZ2H7l3jym_e-6l8FQmi&pullRequest=3540

Check warning on line 279 in test/common/json.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "error" is "std::string *". 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ190QIVSTzC4JOHOn-o&open=AZ190QIVSTzC4JOHOn-o&pullRequest=3540

Check warning on line 309 in test/common/json.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch a more specific exception instead of a generic one. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ190QIVSTzC4JOHOn-p&open=AZ190QIVSTzC4JOHOn-p&pullRequest=3540

Check warning on line 486 in test/benchmark/json_benchmark.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this const reference to "std::string" by a "std::string_view". 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ1-doCWXISY38E6TxpU&open=AZ1-doCWXISY38E6TxpU&pullRequest=3540

Check warning on line 419 in test/benchmark/json_benchmark.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this const reference to "std::string" by a "std::string_view". 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ1-doCWXISY38E6TxpR&open=AZ1-doCWXISY38E6TxpR&pullRequest=3540

Check warning on line 57 in src/request_body_processor/json_adapter.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "sink" is "class modsecurity::RequestBodyProcessor::JsonEventSink *". 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ2H7l3vym_e-6l8FQmk&open=AZ2H7l3vym_e-6l8FQmk&pullRequest=3540

Check warning on line 316 in test/benchmark/json_benchmark.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "unique_ptr" by a raw pointer or a reference (possibly const). 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ2DWE24t-zbsGOGdN_K&open=AZ2DWE24t-zbsGOGdN_K&pullRequest=3540

Check warning on line 13 in src/request_body_processor/json_instrumentation.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use inline variables to define this global variable. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ2H7l0Nym_e-6l8FQmg&open=AZ2H7l0Nym_e-6l8FQmg&pullRequest=3540

Check warning on line 78 in test/common/json.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this member overloaded operator a hidden friend. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ190QIVSTzC4JOHOn-g&open=AZ190QIVSTzC4JOHOn-g&pullRequest=3540

Check warning on line 123 in src/request_body_processor/json.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "m_data". Use the in-class initializer instead. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ190QGTSTzC4JOHOn-D&open=AZ190QGTSTzC4JOHOn-D&pullRequest=3540

Check warning on line 333 in test/common/json.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch a more specific exception instead of a generic one. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ190QIVSTzC4JOHOn-r&open=AZ190QIVSTzC4JOHOn-r&pullRequest=3540

Check failure on line 92 in src/request_body_processor/json_backend_jsoncons.cc

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 33 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AZ190QFsSTzC4JOHOn9w&open=AZ190QFsSTzC4JOHOn9w&pullRequest=3540
View more details on SonarQubeCloud