updating obsolete event handling

Author: shawkins

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/controller/ControllerEventSource.java

@@ -81,6 +81,7 @@ public synchronized void start() {
     }
   }
 
+  @Override
   public synchronized void handleEvent(
       ResourceAction action,
       T resource,
@@ -137,8 +138,8 @@ private boolean isAcceptedByFilters(ResourceAction action, T resource, T oldReso
 
   @Override
   public void onAdd(T resource) {
-    var knownResourceVersion = temporaryResourceCache.onAddOrUpdateEvent(resource);
-    handleEvent(ResourceAction.ADDED, resource, null, null, knownResourceVersion);
+    var obsoleteResourceVersion = temporaryResourceCache.onAddOrUpdateEvent(resource);
+    handleEvent(ResourceAction.ADDED, resource, null, null, obsoleteResourceVersion);
   }
 
   @Override

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/TemporaryResourceCache.java

@@ -93,7 +93,7 @@ public void onDeleteEvent(T resource, boolean unknownState) {
   }
 
   /**
-   * @return true if the resourceVersion was already known and not skipped for event filtering
+   * @return true if the resourceVersion was obsolete
    */
   public boolean onAddOrUpdateEvent(T resource) {
     return onEvent(resource, false, false);
@@ -115,18 +115,18 @@ private synchronized boolean onEvent(T resource, boolean unknownState, boolean d
       latestResourceVersion = resource.getMetadata().getResourceVersion();
     }
     var cached = cache.get(resourceId);
-    boolean filterEvent = false;
+    boolean obsoleteEvent = false;
     int comp = 0;
     if (cached != null) {
       comp = ReconcileUtils.validateAndCompareResourceVersions(resource, cached);
-      if (comp > 0 || unknownState) {
+      if (comp >= 0 || unknownState) {
         cache.remove(resourceId);
         // we propagate event only for our update or newer other can be discarded since we know we
         // will receive
         // additional event
-        filterEvent = false;
+        obsoleteEvent = comp == 0;
       } else {
-        filterEvent = true;
+        obsoleteEvent = true;
       }
     }
     var ed = activeUpdates.get(resourceId);
@@ -138,7 +138,7 @@ private synchronized boolean onEvent(T resource, boolean unknownState, boolean d
                   ResourceAction.UPDATED, resourceId, resource)); // todo true action
       return true;
     } else {
-      return filterEvent;
+      return obsoleteEvent;
     }
   }