[tests] Fix NoReverseMatch in malformed URL tests #682

stktyagi · stktyagi · commit 7e30f8c1cb1b · 2026-01-22T13:42:25.000+05:30
Updated history URL resolution to use admin_urlname for compatibility across different admin namespaces in the CI environment. Fixes #682
diff --git a/openwisp_controller/config/tests/test_admin.py b/openwisp_controller/config/tests/test_admin.py
@@ -1436,7 +1436,7 @@ def test_malformed_admin_urls_return_404(self):
                 )
 
                 # HISTORY URL (kept as existing explicit admin name)
-                history_url_name = f"admin:{model_admin_name}_history"
+                history_url_name = admin_urlname(model_map[model_name]._meta, "history")
                 valid_history_url = reverse(history_url_name, args=[valid_pk])
                 malformed_history_url = f"{valid_history_url}{junk_path}"
 

Original file line number	Diff line number	Diff line change
`@@ -1436,7 +1436,7 @@ def test_malformed_admin_urls_return_404(self):`
`1436`	`1436`	`)`
`1437`	`1437`
`1438`	`1438`	`# HISTORY URL (kept as existing explicit admin name)`
`1439`		`- history_url_name = f"admin:{model_admin_name}_history"`
	`1439`	`+ history_url_name = admin_urlname(model_map[model_name]._meta, "history")`
`1440`	`1440`	`valid_history_url = reverse(history_url_name, args=[valid_pk])`
`1441`	`1441`	`malformed_history_url = f"{valid_history_url}{junk_path}"`
`1442`	`1442`