Skip to content

Commit 2fa65d6

Browse files
committed
[admin] Avoid loading advanced editor for commands #525
Modified JsonSchemaWidget media property to load advanced assets only when advanced_mode=True. CommandSchemaWidget now skips loading unnecessary JS/CSS. Verified config forms load assets, commands do not.
1 parent 6697a3a commit 2fa65d6

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

openwisp_controller/config/widgets.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,18 @@ class JsonSchemaWidget(AdminTextareaWidget):
2020
@property
2121
def media(self):
2222
js = [
23-
"config/js/lib/advanced-mode.js",
24-
"config/js/lib/tomorrow_night_bright.js",
2523
"config/js/lib/jsonschema-ui.js",
2624
"admin/js/jquery.init.js",
2725
"config/js/widget.js",
2826
"config/js/utils.js",
2927
]
3028
css = {
31-
"all": [
32-
f"config/css/{path}"
33-
for path in ("lib/jsonschema-ui.css", "lib/advanced-mode.css")
34-
]
29+
"all": ["config/css/lib/jsonschema-ui.css"]
3530
}
31+
if self.advanced_mode:
32+
js.insert(0, "config/js/lib/advanced-mode.js")
33+
js.insert(1, "config/js/lib/tomorrow_night_bright.js")
34+
css["all"].append("config/css/lib/advanced-mode.css")
3635
return forms.Media(js=js, css=css)
3736

3837
def render(self, name, value, attrs=None, renderer=None):

0 commit comments

Comments
 (0)