From 90db0006ab3ba835ff7265a4e0f77fc2b9fd7a31 Mon Sep 17 00:00:00 2001 From: fracappa Date: Fri, 10 Jul 2026 18:32:21 +0200 Subject: [PATCH] fix: skip MCPs with non-ready nodes during MCN property validation In TNA + Day 2 worker upgrade scenarios, the worker MCP has machines but the nod may by in mid-upgrade and not ready yet. The test would fail trying to validate MCN properties on a node that hasn't converged. Only validate pools where all machines are ready. --- test/extended/machine_config/helpers.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/extended/machine_config/helpers.go b/test/extended/machine_config/helpers.go index 80872a698926..e1cf3f8adcbc 100644 --- a/test/extended/machine_config/helpers.go +++ b/test/extended/machine_config/helpers.go @@ -134,10 +134,10 @@ func GetRolesToTest(oc *exutil.CLI, machineConfigClient *machineconfigclient.Cli mcps, mcpErr := machineConfigClient.MachineconfigurationV1().MachineConfigPools().List(context.TODO(), metav1.ListOptions{}) o.Expect(mcpErr).NotTo(o.HaveOccurred(), "Error getting MCPs.") - // For any MCP with machines, add the MCP name as a role to test. + /// For any MCP with machines where all machines are ready, add the MCP name as a role to test. var rolesToTest []string for _, mcp := range mcps.Items { - if mcp.Status.MachineCount > 0 { + if mcp.Status.MachineCount > 0 && mcp.Status.ReadyMachineCount == mcp.Status.MachineCount { rolesToTest = append(rolesToTest, mcp.Name) } }