Remove Firehose Component and Fix and Cleanup Impacted Types

Author: cajieh

frontend/packages/console-shared/src/components/formik-fields/ResourceDropdownField.tsx

@@ -1,4 +1,5 @@
 import type { FC } from 'react';
+import { useMemo } from 'react';
 import { FormGroup, FormHelperText, HelperText, HelperTextItem } from '@patternfly/react-core';
 import type { FormikValues } from 'formik';
 import { useField, useFormikContext } from 'formik';
@@ -49,6 +50,19 @@ const ResourceDropdownField: FC<ResourceDropdownFieldProps> = ({
 
   useFormikValidationFix(field.value);
 
+  // ResourceDropdown expects these as top-level props to manage loading state
+  const { loaded, loadError } = useMemo(() => {
+    if (!resources) {
+      return { loaded: true, loadError: undefined };
+    }
+    const allLoaded = resources.every((r) => r.loaded);
+    const resourceWithLoadError = resources.find((r) => r.loadError);
+    return {
+      loaded: allLoaded,
+      loadError: resourceWithLoadError?.loadError,
+    };
+  }, [resources]);
+
   return (
     <FormGroup fieldId={fieldId} label={label} isRequired={required} data-test={dataTest}>
       <ResourceDropdown
@@ -60,6 +74,8 @@ const ResourceDropdownField: FC<ResourceDropdownFieldProps> = ({
         onLoad={onLoad}
         resourceFilter={resourceFilter}
         resources={resources}
+        loaded={loaded}
+        loadError={loadError}
         onChange={(value: string, name: string | object, resource: K8sResourceKind) => {
           props.onChange && props.onChange(value, name, resource);
           setFieldValue(props.name, value);

frontend/packages/integration-tests-cypress/views/details-page.ts

@@ -13,7 +13,10 @@ export const detailsPage = {
   clickPageActionButton: (action: string) => {
     cy.byLegacyTestID('details-actions').contains(action).click();
   },
-  isLoaded: () => cy.byTestID('skeleton-detail-view').should('not.exist'),
+  isLoaded: () => {
+    cy.byTestID('skeleton-detail-view').should('not.exist');
+    cy.get('[data-test-id="resource-title"]', { timeout: 30000 }).should('not.be.empty');
+  },
   breadcrumb: (breadcrumbIndex: number) => cy.byLegacyTestID(`breadcrumb-link-${breadcrumbIndex}`),
   selectTab: (name: string) => {
     cy.get(`a[data-test-id="horizontal-link-${name}"]`).should('exist').click();

frontend/packages/operator-lifecycle-manager/src/components/operator-install-page.tsx

@@ -390,7 +390,9 @@ const OperatorInstallStatus: FC<OperatorInstallPageProps> = ({ resources }) => {
   const launchModal = useOverlay();
   const { currentCSV, targetNamespace } = useParams<OperatorInstallStatusPageRouteParams>();
 
-  const loadError = Object.values(resources || {}).find((r) => r?.loadError)?.loadError;
+  const subscriptionLoadError = resources?.subscription?.loadError;
+  const csvLoadError = resources?.clusterServiceVersion?.loadError;
+  const loadError = subscriptionLoadError || (csvLoadError && !resources?.subscription?.data);
 
   let loading = true;
   let status = '';

frontend/public/components/cron-job.tsx

@@ -412,6 +412,9 @@ export const CronJobsPage: FC<CronJobsPageProps> = (props) => (
 
 export const CronJobsDetailsPage: FC = (props) => {
   const customActionMenu = (kindObj, obj) => {
+    if (!kindObj || !obj) {
+      return null;
+    }
     const resourceKind = referenceForModel(kindObj);
     const context = { [resourceKind]: obj };
     return (