From c4ea330484d25bf0051e9a49a02cdb9d4e43d25c Mon Sep 17 00:00:00 2001 From: aksjadha Date: Wed, 20 May 2026 23:40:43 +0530 Subject: [PATCH 1/2] Add KubeletConfigAccepted const in 'machineconfiguration/v1/types.go' --- machineconfiguration/v1/types.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/machineconfiguration/v1/types.go b/machineconfiguration/v1/types.go index 21615ee9aa4..7c707cc5a22 100644 --- a/machineconfiguration/v1/types.go +++ b/machineconfiguration/v1/types.go @@ -811,6 +811,11 @@ type KubeletConfigCondition struct { type KubeletConfigStatusConditionType string const ( + // KubeletConfigAccepted designates whether a KubeletConfig CR has been accepted. + // When the condition status is True, the KubeletConfig has been accepted successfully. + // When the condition status is False, the KubeletConfig has not been accepted. + KubeletConfigAccepted KubeletConfigStatusConditionType = "KubeletConfig has been accepted" + // KubeletConfigSuccess designates a successful application of a KubeletConfig CR. KubeletConfigSuccess KubeletConfigStatusConditionType = "Success" From a5ee1dbcbf59d31190e5304c42a4aab004d12d69 Mon Sep 17 00:00:00 2001 From: aksjadha Date: Tue, 26 May 2026 12:20:20 +0530 Subject: [PATCH 2/2] Fix KubeletConfigAccepted condition type to follow Kubernetes API conventions --- machineconfiguration/v1/types.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/machineconfiguration/v1/types.go b/machineconfiguration/v1/types.go index 7c707cc5a22..33c12be9235 100644 --- a/machineconfiguration/v1/types.go +++ b/machineconfiguration/v1/types.go @@ -811,15 +811,17 @@ type KubeletConfigCondition struct { type KubeletConfigStatusConditionType string const ( - // KubeletConfigAccepted designates whether a KubeletConfig CR has been accepted. - // When the condition status is True, the KubeletConfig has been accepted successfully. - // When the condition status is False, the KubeletConfig has not been accepted. - KubeletConfigAccepted KubeletConfigStatusConditionType = "KubeletConfig has been accepted" + // KubeletConfigAccepted designates whether a KubeletConfig CR has been accepted. + // When the condition status is True, the KubeletConfig has been accepted successfully. + // When the condition status is False, the KubeletConfig has not been accepted. + KubeletConfigAccepted KubeletConfigStatusConditionType = "Accepted" // KubeletConfigSuccess designates a successful application of a KubeletConfig CR. + // Deprecated: Use KubeletConfigAccepted instead. KubeletConfigSuccess will be removed in a future release. KubeletConfigSuccess KubeletConfigStatusConditionType = "Success" // KubeletConfigFailure designates a failure applying a KubeletConfig CR. + // Deprecated: Use KubeletConfigAccepted with status False instead. KubeletConfigFailure will be removed in a future release. KubeletConfigFailure KubeletConfigStatusConditionType = "Failure" )