feat: promoting feature gate AWSServiceLBNetworkSecurityGroup

mtulio · mtulio · commit 98fa4f350098 · 2026-03-09T11:09:07.000-03:00
This change promotes the feature gate AWSServiceLBNetworkSecurityGroup from TechPreviewNoUpgrade to Default feature set on self-managed. Also the feature AWSServiceLBNetworkSecurityGroup is kept TP and DP on Hypershift while the implementation is finished on Hypershift. The tests covering this feature is added by openshift/cloud-provider-aws#129.
diff --git a/features.md b/features.md
@@ -23,7 +23,6 @@
 | AWSClusterHostedDNSInstall| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | AWSDedicatedHosts| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | AWSDualStackInstall| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
-| AWSServiceLBNetworkSecurityGroup| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | AdditionalStorageConfig| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | AutomatedEtcdBackup| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | AzureClusterHostedDNSInstall| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
@@ -89,6 +88,7 @@
 | VSphereHostVMGroupZonal| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | VSphereMixedNodeEnv| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | VolumeGroupSnapshot| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
+| AWSServiceLBNetworkSecurityGroup| | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | AzureWorkloadIdentity| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | BuildCSIVolumes| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | ConsolePluginContentSecurityPolicy| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
diff --git a/features/features.go b/features/features.go
@@ -841,12 +841,13 @@ var (
 					mustRegister()
 
 	FeatureGateAWSServiceLBNetworkSecurityGroup = newFeatureGate("AWSServiceLBNetworkSecurityGroup").
-							reportProblemsToJiraComponent("Cloud Compute / Cloud Controller Manager").
-							contactPerson("mtulio").
-							productScope(ocpSpecific).
-							enhancementPR("https://github.com/openshift/enhancements/pull/1802").
-							enable(inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
-							mustRegister()
+					reportProblemsToJiraComponent("Cloud Compute / Cloud Controller Manager").
+					contactPerson("mtulio").
+					productScope(ocpSpecific).
+					enhancementPR("https://github.com/openshift/enhancements/pull/1802").
+					enable(inClusterProfile(SelfManaged), inDefault(), inOKD(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
+					enable(inClusterProfile(Hypershift), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
+					mustRegister()
 
 	FeatureGateImageVolume = newFeatureGate("ImageVolume").
 				reportProblemsToJiraComponent("Node").
diff --git a/payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml b/payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
@@ -26,9 +26,6 @@
                     {
                         "name": "AWSDualStackInstall"
                     },
-                    {
-                        "name": "AWSServiceLBNetworkSecurityGroup"
-                    },
                     {
                         "name": "AdditionalStorageConfig"
                     },
@@ -274,6 +271,9 @@
                     }
                 ],
                 "enabled": [
+                    {
+                        "name": "AWSServiceLBNetworkSecurityGroup"
+                    },
                     {
                         "name": "AzureWorkloadIdentity"
                     },
diff --git a/payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml b/payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
@@ -28,9 +28,6 @@
                     {
                         "name": "AWSDualStackInstall"
                     },
-                    {
-                        "name": "AWSServiceLBNetworkSecurityGroup"
-                    },
                     {
                         "name": "AdditionalStorageConfig"
                     },
@@ -276,6 +273,9 @@
                     }
                 ],
                 "enabled": [
+                    {
+                        "name": "AWSServiceLBNetworkSecurityGroup"
+                    },
                     {
                         "name": "AzureWorkloadIdentity"
                     },

Original file line number	Diff line number	Diff line change
`@@ -26,9 +26,6 @@`
`26`	`26`	`{`
`27`	`27`	`"name": "AWSDualStackInstall"`
`28`	`28`	`},`
`29`		`- {`
`30`		`- "name": "AWSServiceLBNetworkSecurityGroup"`
`31`		`- },`
`32`	`29`	`{`
`33`	`30`	`"name": "AdditionalStorageConfig"`
`34`	`31`	`},`
`@@ -274,6 +271,9 @@`
`274`	`271`	`}`
`275`	`272`	`],`
`276`	`273`	`"enabled": [`
	`274`	`+ {`
	`275`	`+ "name": "AWSServiceLBNetworkSecurityGroup"`
	`276`	`+ },`
`277`	`277`	`{`
`278`	`278`	`"name": "AzureWorkloadIdentity"`
`279`	`279`	`},`
Original file line number	Diff line number	Diff line change
`@@ -28,9 +28,6 @@`
`28`	`28`	`{`
`29`	`29`	`"name": "AWSDualStackInstall"`
`30`	`30`	`},`
`31`		`- {`
`32`		`- "name": "AWSServiceLBNetworkSecurityGroup"`
`33`		`- },`
`34`	`31`	`{`
`35`	`32`	`"name": "AdditionalStorageConfig"`
`36`	`33`	`},`
`@@ -276,6 +273,9 @@`
`276`	`273`	`}`
`277`	`274`	`],`
`278`	`275`	`"enabled": [`
	`276`	`+ {`
	`277`	`+ "name": "AWSServiceLBNetworkSecurityGroup"`
	`278`	`+ },`
`279`	`279`	`{`
`280`	`280`	`"name": "AzureWorkloadIdentity"`
`281`	`281`	`},`