remove RouteExternalCertificate feature gate

jcmoraisjr · jcmoraisjr · commit 6d766506aadf · 2026-02-05T09:38:55.000-03:00
RouteExternalCertificate is enabled by default, this is the second half of the changes to remove it and should be merged only after openshift/cluster-ingress-operator#1355 being merged.
diff --git a/features.md b/features.md
@@ -101,7 +101,6 @@
 | MetricsCollectionProfiles| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | OpenShiftPodSecurityAdmission| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | PinnedImages| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
-| RouteExternalCertificate| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | ServiceAccountTokenNodeBinding| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | SigstoreImageVerification| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | SigstoreImageVerificationPKI| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
diff --git a/features/features.go b/features/features.go
@@ -155,14 +155,6 @@ var (
 					enableIn(configv1.Default, configv1.OKD, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
 					mustRegister()
 
-	FeatureGateRouteExternalCertificate = newFeatureGate("RouteExternalCertificate").
-						reportProblemsToJiraComponent("router").
-						contactPerson("chiragkyal").
-						productScope(ocpSpecific).
-						enhancementPR(legacyFeatureGateWithoutEnhancement).
-						enableIn(configv1.Default, configv1.OKD, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
-						mustRegister()
-
 	FeatureGateCPMSMachineNamePrefix = newFeatureGate("CPMSMachineNamePrefix").
 						reportProblemsToJiraComponent("Cloud Compute / ControlPlaneMachineSet").
 						contactPerson("chiragkyal").
diff --git a/openapi/generated_openapi/zz_generated.openapi.go b/openapi/generated_openapi/zz_generated.openapi.go
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml b/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
@@ -317,9 +317,6 @@
                     {
                         "name": "PinnedImages"
                     },
-                    {
-                        "name": "RouteExternalCertificate"
-                    },
                     {
                         "name": "ServiceAccountTokenNodeBinding"
                     },
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml
@@ -301,9 +301,6 @@
                     {
                         "name": "ProvisioningRequestAvailable"
                     },
-                    {
-                        "name": "RouteExternalCertificate"
-                    },
                     {
                         "name": "SELinuxMount"
                     },
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-OKD.yaml b/payload-manifests/featuregates/featureGate-Hypershift-OKD.yaml
@@ -319,9 +319,6 @@
                     {
                         "name": "PinnedImages"
                     },
-                    {
-                        "name": "RouteExternalCertificate"
-                    },
                     {
                         "name": "ServiceAccountTokenNodeBinding"
                     },
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
@@ -301,9 +301,6 @@
                     {
                         "name": "PinnedImages"
                     },
-                    {
-                        "name": "RouteExternalCertificate"
-                    },
                     {
                         "name": "SELinuxMount"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
@@ -317,9 +317,6 @@
                     {
                         "name": "PinnedImages"
                     },
-                    {
-                        "name": "RouteExternalCertificate"
-                    },
                     {
                         "name": "ServiceAccountTokenNodeBinding"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml
@@ -301,9 +301,6 @@
                     {
                         "name": "ProvisioningRequestAvailable"
                     },
-                    {
-                        "name": "RouteExternalCertificate"
-                    },
                     {
                         "name": "SELinuxMount"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-OKD.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-OKD.yaml
@@ -319,9 +319,6 @@
                     {
                         "name": "PinnedImages"
                     },
-                    {
-                        "name": "RouteExternalCertificate"
-                    },
                     {
                         "name": "ServiceAccountTokenNodeBinding"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
@@ -301,9 +301,6 @@
                     {
                         "name": "PinnedImages"
                     },
-                    {
-                        "name": "RouteExternalCertificate"
-                    },
                     {
                         "name": "SELinuxMount"
                     },

Original file line number	Diff line number	Diff line change
`@@ -317,9 +317,6 @@`
`317`	`317`	`{`
`318`	`318`	`"name": "PinnedImages"`
`319`	`319`	`},`
`320`		`- {`
`321`		`- "name": "RouteExternalCertificate"`
`322`		`- },`
`323`	`320`	`{`
`324`	`321`	`"name": "ServiceAccountTokenNodeBinding"`
`325`	`322`	`},`
Original file line number	Diff line number	Diff line change
`@@ -301,9 +301,6 @@`
`301`	`301`	`{`
`302`	`302`	`"name": "ProvisioningRequestAvailable"`
`303`	`303`	`},`
`304`		`- {`
`305`		`- "name": "RouteExternalCertificate"`
`306`		`- },`
`307`	`304`	`{`
`308`	`305`	`"name": "SELinuxMount"`
`309`	`306`	`},`
Original file line number	Diff line number	Diff line change
`@@ -319,9 +319,6 @@`
`319`	`319`	`{`
`320`	`320`	`"name": "PinnedImages"`
`321`	`321`	`},`
`322`		`- {`
`323`		`- "name": "RouteExternalCertificate"`
`324`		`- },`
`325`	`322`	`{`
`326`	`323`	`"name": "ServiceAccountTokenNodeBinding"`
`327`	`324`	`},`