Always regenerate go2rtc config fresh at startup

Fixes stale/corrupted go2rtc.yaml configs from prior versions causing
stream errors (0x0 resolution, Error state).

- docker-entrypoint.sh: Always remove and recreate go2rtc.yaml on
  container startup instead of only when it doesn't exist. Removes
  the now-unnecessary patching logic for base_path and origin.
- go2rtc_process_start(): Always call go2rtc_process_generate_config()
  at the top of the function, even when go2rtc is already running,
  so the config stays in sync with lightNVR settings.

Fixes #165

Author: matteius

docker-entrypoint.sh

@@ -165,11 +165,16 @@ EOF
     # Create go2rtc config directory if it doesn't exist
     mkdir -p /etc/lightnvr/go2rtc
 
-    # Create default go2rtc.yaml if it doesn't exist
-    # Only create if GO2RTC_CONFIG_PERSIST is true (default)
-    if [ ! -f /etc/lightnvr/go2rtc/go2rtc.yaml ] && [ "${GO2RTC_CONFIG_PERSIST:-true}" = "true" ]; then
-        log_info "Creating default go2rtc configuration..."
-        cat > /etc/lightnvr/go2rtc/go2rtc.yaml << 'EOF'
+    # Always regenerate go2rtc.yaml fresh at startup to avoid stale/corrupted
+    # configs from prior versions causing stream errors (see issue #165).
+    # The C code in go2rtc_process_generate_config() will overwrite this with
+    # the full config derived from lightNVR settings once the application starts.
+    if [ -f /etc/lightnvr/go2rtc/go2rtc.yaml ]; then
+        log_info "Removing old go2rtc configuration to regenerate fresh..."
+        rm -f /etc/lightnvr/go2rtc/go2rtc.yaml
+    fi
+    log_info "Creating default go2rtc configuration..."
+    cat > /etc/lightnvr/go2rtc/go2rtc.yaml << 'EOF'
 # go2rtc configuration file
 api:
   listen: :1984
@@ -193,28 +198,7 @@ log:
 streams:
   # Streams will be added dynamically by LightNVR
 EOF
-        log_info "Default go2rtc configuration created at /etc/lightnvr/go2rtc/go2rtc.yaml"
-    fi
-
-    # Ensure existing go2rtc configs have required settings
-    if [ -f /etc/lightnvr/go2rtc/go2rtc.yaml ]; then
-        # Ensure base_path: /go2rtc is set - lightNVR C code prefixes ALL go2rtc API calls
-        # with /go2rtc (GO2RTC_BASE_PATH), so go2rtc must be configured to serve on that path.
-        # Without this, readiness checks hit /go2rtc/api/streams which returns 404.
-        if ! grep -q 'base_path:' /etc/lightnvr/go2rtc/go2rtc.yaml 2>/dev/null; then
-            log_warn "go2rtc config missing base_path setting - adding base_path: /go2rtc for lightNVR compatibility"
-            sed -i '/listen: :1984/a\  base_path: /go2rtc' /etc/lightnvr/go2rtc/go2rtc.yaml
-            log_info "Added base_path to go2rtc configuration"
-        fi
-
-        # Ensure CORS origin is set
-        # Without origin: "*", browsers block cross-origin requests from the web UI (:8080) to go2rtc (:1984)
-        if ! grep -q 'origin:' /etc/lightnvr/go2rtc/go2rtc.yaml 2>/dev/null; then
-            log_warn "go2rtc config missing CORS origin setting - adding origin: \"*\" for browser compatibility"
-            sed -i '/listen: :1984/a\  origin: "*"' /etc/lightnvr/go2rtc/go2rtc.yaml
-            log_info "Added CORS origin to go2rtc configuration"
-        fi
-    fi
+    log_info "Default go2rtc configuration created at /etc/lightnvr/go2rtc/go2rtc.yaml"
 
     # Set up models if needed
     if [ -d /usr/share/lightnvr/models ] && [ -n "$(ls -A /usr/share/lightnvr/models 2>/dev/null)" ]; then

src/video/go2rtc/go2rtc_process.c

@@ -1013,6 +1013,16 @@ bool go2rtc_process_start(int api_port) {
         return false;
     }
 
+    // Always regenerate the go2rtc config file fresh at startup to avoid
+    // stale/corrupted configs from prior versions causing stream errors
+    // (see issue #165). The file is opened with O_TRUNC so any old content
+    // is discarded.
+    log_info("Regenerating go2rtc configuration file fresh at startup");
+    if (!go2rtc_process_generate_config(g_config_path, api_port)) {
+        log_warn("Failed to regenerate go2rtc configuration at startup");
+        // Continue anyway - the old config may still work
+    }
+
     // Check if go2rtc is already running as a service
     if (is_go2rtc_running_as_service(api_port)) {
         log_info("go2rtc is already running as a service on port %d, using existing service", api_port);
@@ -1084,12 +1094,6 @@ bool go2rtc_process_start(int api_port) {
         return false;
     }
 
-    // Generate configuration file
-    if (!go2rtc_process_generate_config(g_config_path, api_port)) {
-        log_error("Failed to generate go2rtc configuration");
-        return false;
-    }
-
     // Seed g_rtsp_port from the user-configured value before starting the process.
     // This ensures that if the post-start API call fails (e.g. because another
     // service such as mediamtx already holds the default port 8554), the fallback