v0.19.0: Remove deprecated features with data migrations

- Migration 0040: Migrate show_if_field/show_if_value to conditional_rules,
  clear orphan flat approval_groups, clear escalation fields, mark
  auto_created stages as real, clear old visual_workflow_data format
- Migration 0041: Drop 12 deprecated fields (approval_groups M2M,
  approval_logic, requires_manager_approval, manager_can_override_group,
  escalation_field, escalation_threshold, escalation_groups M2M,
  enable_db_updates, db_update_mappings, show_if_field, show_if_value,
  auto_created)
- Remove ~160 lines of legacy flat workflow engine code
- Remove approval_config node type from visual builder
- Remove escalation UI from workflow settings panel
- Update sync_api to gracefully discard legacy keys on import
- Clean up admin, forms, views, tasks, utils, management commands

Author: matteius

django_forms_workflows/admin.py

@@ -84,7 +84,7 @@ class FormFieldInline(admin.StackedInline):
             "Conditional display",
             {
                 "classes": ("collapse",),
-                "fields": (("show_if_field", "show_if_value"),),
+                "fields": ("conditional_rules",),
             },
         ),
         (
@@ -275,16 +275,10 @@ class WorkflowDefinitionInline(admin.StackedInline):
     extra = 0
     fields = [
         "requires_approval",
-        ("approval_groups", "approval_logic"),
-        "requires_manager_approval",
-        ("escalation_field", "escalation_threshold", "escalation_groups"),
         ("notify_on_submission", "notify_on_approval", "notify_on_rejection"),
         "additional_notify_emails",
-        "enable_db_updates",
-        "db_update_mappings",
         ("allow_bulk_export", "allow_bulk_pdf_export"),
     ]
-    filter_horizontal = ["approval_groups", "escalation_groups"]
 
 
 @admin.register(FormDefinition)
@@ -497,8 +491,7 @@ def clone_forms(self, request, queryset):
                             max_length=field.max_length,
                             regex_validation=field.regex_validation,
                             regex_error_message=field.regex_error_message,
-                            show_if_field=field.show_if_field,
-                            show_if_value=field.show_if_value,
+                            conditional_rules=field.conditional_rules,
                             allowed_extensions=field.allowed_extensions,
                             max_file_size_mb=field.max_file_size_mb,
                         )
@@ -937,48 +930,25 @@ class WorkflowDefinitionAdmin(admin.ModelAdmin):
     list_display = (
         "form_definition",
         "requires_approval",
-        "approval_logic",
-        "requires_manager_approval",
         "allow_bulk_export",
         "allow_bulk_pdf_export",
     )
     list_filter = (
         "requires_approval",
-        "approval_logic",
-        "requires_manager_approval",
         "allow_bulk_export",
         "allow_bulk_pdf_export",
     )
     search_fields = ("form_definition__name",)
-    filter_horizontal = ("approval_groups", "escalation_groups")
     fieldsets = (
         (
             None,
             {
                 "fields": (
                     "form_definition",
-                    ("requires_approval", "approval_logic"),
-                    "approval_groups",
+                    "requires_approval",
                 )
             },
         ),
-        (
-            "Manager approval",
-            {
-                "classes": ("collapse",),
-                "fields": ("requires_manager_approval", "manager_can_override_group"),
-            },
-        ),
-        (
-            "Conditional escalation",
-            {
-                "classes": ("collapse",),
-                "fields": (
-                    ("escalation_field", "escalation_threshold"),
-                    "escalation_groups",
-                ),
-            },
-        ),
         (
             "Timeouts",
             {
@@ -1023,13 +993,6 @@ class WorkflowDefinitionAdmin(admin.ModelAdmin):
                 ),
             },
         ),
-        (
-            "Post-approval DB updates",
-            {
-                "classes": ("collapse",),
-                "fields": ("enable_db_updates", "db_update_mappings"),
-            },
-        ),
         (
             "Bulk Export",
             {

django_forms_workflows/form_builder_views.py

@@ -133,8 +133,7 @@ def form_builder_clone(request, form_id):
                     max_length=field.max_length,
                     regex_validation=field.regex_validation,
                     regex_error_message=field.regex_error_message,
-                    show_if_field=field.show_if_field,
-                    show_if_value=field.show_if_value,
+                    conditional_rules=field.conditional_rules,
                     allowed_extensions=field.allowed_extensions,
                     max_file_size_mb=field.max_file_size_mb,
                 )
@@ -229,8 +228,7 @@ def form_builder_load(request, form_id):
                 "regex_error_message": field.regex_error_message or "",
             },
             "conditional": {
-                "show_if_field": field.show_if_field,
-                "show_if_value": field.show_if_value or "",
+                "conditional_rules": field.conditional_rules or [],
             },
             "workflow_stage_id": field.workflow_stage_id,
         }
@@ -377,17 +375,15 @@ def form_builder_save(request):
 
                 # Add conditional properties
                 conditional = field_data.get("conditional", {})
-                field_props.update(
-                    {
-                        "show_if_field": conditional.get("show_if_field", ""),
-                        "show_if_value": conditional.get("show_if_value", ""),
-                    }
+                conditional_rules = conditional.get(
+                    "conditional_rules",
+                    field_data.get("conditional_rules"),
                 )
 
                 # Add client-side enhancement properties
                 field_props.update(
                     {
-                        "conditional_rules": field_data.get("conditional_rules"),
+                        "conditional_rules": conditional_rules,
                         "validation_rules": field_data.get("validation_rules"),
                         "field_dependencies": field_data.get("field_dependencies"),
                         "step_number": field_data.get("step_number"),
@@ -530,10 +526,10 @@ def form_builder_preview(request):
                 if validation.get("max_length") is not None:
                     field_kwargs["max_length"] = validation.get("max_length")
 
-                # Only set show_if_field if it has a value (SlugField doesn't accept empty string)
-                if conditional.get("show_if_field"):
-                    field_kwargs["show_if_field"] = conditional.get("show_if_field")
-                    field_kwargs["show_if_value"] = conditional.get("show_if_value", "")
+                # Conditional rules
+                cond_rules = conditional.get("conditional_rules")
+                if cond_rules:
+                    field_kwargs["conditional_rules"] = cond_rules
 
                 FormField.objects.create(**field_kwargs)
 

django_forms_workflows/forms.py

@@ -482,25 +482,8 @@ def get_enhancements_config(self):
 
         # Collect conditional rules from all fields
         for field in self.form_definition.fields.all():
-            # Legacy simple conditional logic
-            if field.show_if_field and field.show_if_value:
-                config["conditionalRules"].append(
-                    {
-                        "targetField": field.field_name,
-                        "action": "show",
-                        "operator": "AND",
-                        "conditions": [
-                            {
-                                "field": field.show_if_field,
-                                "operator": "equals",
-                                "value": field.show_if_value,
-                            }
-                        ],
-                    }
-                )
-
-            # Advanced conditional rules
-            if hasattr(field, "conditional_rules") and field.conditional_rules:
+            # Conditional rules
+            if field.conditional_rules:
                 if isinstance(field.conditional_rules, str):
                     try:
                         rules = json.loads(field.conditional_rules)

django_forms_workflows/management/commands/create_default_templates.py

@@ -52,7 +52,7 @@ def handle(self, *args, **options):
                                 "regex_validation": "",
                                 "regex_error_message": "",
                             },
-                            "conditional": {"show_if_field": "", "show_if_value": ""},
+                            "conditional": {},
                         },
                         {
                             "order": 2,
@@ -75,7 +75,7 @@ def handle(self, *args, **options):
                                 "regex_validation": "",
                                 "regex_error_message": "",
                             },
-                            "conditional": {"show_if_field": "", "show_if_value": ""},
+                            "conditional": {},
                         },
                         {
                             "order": 3,
@@ -98,7 +98,7 @@ def handle(self, *args, **options):
                                 "regex_validation": "",
                                 "regex_error_message": "",
                             },
-                            "conditional": {"show_if_field": "", "show_if_value": ""},
+                            "conditional": {},
                         },
                         {
                             "order": 4,
@@ -121,7 +121,7 @@ def handle(self, *args, **options):
                                 "regex_validation": "",
                                 "regex_error_message": "",
                             },
-                            "conditional": {"show_if_field": "", "show_if_value": ""},
+                            "conditional": {},
                         },
                     ],
                 },

django_forms_workflows/management/commands/seed_farm_demo.py

@@ -1,5 +1,4 @@
 import json
-from decimal import Decimal
 
 from django.contrib.auth.models import Group, User
 from django.core.management.base import BaseCommand
@@ -180,16 +179,20 @@ def handle(self, *args, **options):
         )
         # Ensure associations and settings
         wf1.requires_approval = True
-        wf1.approval_logic = "any"
         wf1.approval_deadline_days = 7
         wf1.send_reminder_after_days = 3
-        wf1.escalation_field = "cost_estimate"
-        wf1.escalation_threshold = Decimal("1000.00")
         wf1.save()
-        wf1.approval_groups.set(
+        # Create a stage for approval
+        from django_forms_workflows.models import WorkflowStage
+
+        stage1, _ = WorkflowStage.objects.get_or_create(
+            workflow=wf1,
+            order=1,
+            defaults={"name": "Review", "approval_logic": "any"},
+        )
+        stage1.approval_groups.set(
             [groups["Barn Managers"], groups["Equipment Operators"]]
         )
-        wf1.escalation_groups.set([groups["Farm Owners"]])
         self.stdout.write(
             self.style.SUCCESS("Configured workflow for Equipment Repair Request")
         )
@@ -243,17 +246,20 @@ def handle(self, *args, **options):
             form_definition=fd2,
             defaults={
                 "requires_approval": True,
-                "approval_logic": "all",
                 "approval_deadline_days": 5,
                 "send_reminder_after_days": 2,
             },
         )
         wf2.requires_approval = True
-        wf2.approval_logic = "all"
         wf2.approval_deadline_days = 5
         wf2.send_reminder_after_days = 2
         wf2.save()
-        wf2.approval_groups.set([groups["Field Crew"], groups["Barn Managers"]])
+        stage2, _ = WorkflowStage.objects.get_or_create(
+            workflow=wf2,
+            order=1,
+            defaults={"name": "Review", "approval_logic": "all"},
+        )
+        stage2.approval_groups.set([groups["Field Crew"], groups["Barn Managers"]])
         self.stdout.write(
             self.style.SUCCESS("Configured workflow for Barn Maintenance Request")
         )