Fix select_related('workflow') → prefetch_related('workflows') in ajax views

select_related cannot traverse reverse ForeignKey relations. Changed three
DataTables ajax views (pending, completed, admin approvals) to use
prefetch_related('form_definition__workflows') instead.

Also fix sync_api import hasattr check for sub-workflow config.

Fixes: completedTable Ajax error on test3.
Bump version to 0.23.2

Author: matteius

django_forms_workflows/sync_api.py

@@ -579,11 +579,12 @@ def import_form(form_data, conflict="update", category_cache=None):
         if sub_wf_data:
             sub_form_slug = sub_wf_data.get("sub_workflow_form_slug")
             sub_wf_form = FormDefinition.objects.filter(slug=sub_form_slug).first()
-            if sub_wf_form and hasattr(sub_wf_form, "workflow"):
+            sub_wf = sub_wf_form.workflow if sub_wf_form else None
+            if sub_wf:
                 SubWorkflowDefinition.objects.update_or_create(
                     parent_workflow=wf,
                     defaults={
-                        "sub_workflow": sub_wf_form.workflow,
+                        "sub_workflow": sub_wf,
                         "section_label": sub_wf_data.get("section_label", ""),
                         "count_field": sub_wf_data.get("count_field", ""),
                         "label_template": sub_wf_data.get(

django_forms_workflows/views.py

@@ -2464,8 +2464,8 @@ def completed_approvals_ajax(request):
 
     # --- Page slice ---
     base_qs = qs.select_related(
-        "form_definition__category", "form_definition__workflow", "submitter"
-    )
+        "form_definition__category", "submitter"
+    ).prefetch_related("form_definition__workflows")
     # Only defer form_data when we don't need it (no per-form column expansion).
     # .defer(None) is invalid Django — conditionally apply instead.
     if not form_slug:
@@ -2591,9 +2591,8 @@ def approval_inbox_ajax(request):
     # --- Page slice ---
     page_qs = qs.select_related(
         "submission__form_definition__category",
-        "submission__form_definition__workflow",
         "submission__submitter",
-    )[start : start + length]
+    ).prefetch_related("submission__form_definition__workflows")[start : start + length]
 
     # --- Serialise ---
     data = []
@@ -2692,8 +2691,8 @@ def my_submissions_ajax(request):
         except FormDefinition.DoesNotExist:
             pass
 
-    base_qs = qs.select_related(
-        "form_definition__category", "form_definition__workflow"
+    base_qs = qs.select_related("form_definition__category").prefetch_related(
+        "form_definition__workflows"
     )
     if not form_slug:
         base_qs = base_qs.defer("form_data")

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "django-forms-workflows"
-version = "0.23.1"
+version = "0.23.2"
 description = "Enterprise-grade, database-driven form builder with approval workflows and external data integration"
 license = "LGPL-3.0-only"
 readme = "README.md"