-
-
Notifications
You must be signed in to change notification settings - Fork 50
Open
Labels
Description
Describe the bug
The /tasktype/{task_type_id} endpoint is not robust to unexpected api_constraints values.
In src/routers/openml/tasktype.py, the current parsing assumes a valid JSON string containing data_type. If api_constraints is malformed JSON, already a dict, or missing data_type, the endpoint may fail or behave inconsistently.
To Reproduce
Minimal reproducible setup (data-level reproduction):
- Ensure a task type exists with at least one input row in the DB.
- Set
api_constraintsfor that input to malformed JSON, for example:"{bad json"
- Call:
GET /tasktype/<task_type_id>
Also test with:
api_constraintsalready stored as a dict/object-like value (if DB layer returns dict)api_constraintsvalid JSON but withoutdata_type, e.g.{"foo":"bar"}
Expected behavior
- The endpoint should return a stable response and should not crash.
- It should accept both legacy JSON strings and dict-like values.
- It should include
input[].data_typeonly whendata_typeis present. - Malformed JSON in
api_constraintsshould be ignored gracefully for that field.
Additional context
Proposed fix is to make parsing defensive:
- parse string values via
json.loadsinsidetry/except json.JSONDecodeError - accept dict values directly
- set
data_typeconditionally using safe lookup
Reactions are currently unavailable