Skip to content

Commit 04c533f

Browse files
made get_users a private func
1 parent 152bfef commit 04c533f

2 files changed

Lines changed: 2 additions & 15 deletions

File tree

openml/_api/resources/base.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,3 @@ def list( # noqa: PLR0913
4949
sort_order: str | None = None,
5050
**kwargs: Any,
5151
) -> list[OpenMLEvaluation]: ...
52-
53-
@abstractmethod
54-
def get_users(self, uploader_ids: list[str]) -> dict: ...

openml/_api/resources/evaluations.py

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ def _parse_list_xml(self, xml_content: str) -> list[OpenMLEvaluation]:
195195
uploader_ids = list(
196196
{eval_["oml:uploader"] for eval_ in evals_dict["oml:evaluations"]["oml:evaluation"]},
197197
)
198-
user_dict = self.get_users(uploader_ids)
198+
user_dict = self._get_users(uploader_ids)
199199

200200
evals = []
201201
for eval_ in evals_dict["oml:evaluations"]["oml:evaluation"]:
@@ -225,7 +225,7 @@ def _parse_list_xml(self, xml_content: str) -> list[OpenMLEvaluation]:
225225

226226
return evals
227227

228-
def get_users(self, uploader_ids: list[str]) -> dict:
228+
def _get_users(self, uploader_ids: list[str]) -> dict:
229229
"""
230230
Retrieve usernames for a list of OpenML user IDs.
231231
@@ -275,13 +275,3 @@ def list( # noqa: PLR0913
275275
This method is not yet implemented.
276276
"""
277277
raise NotImplementedError("V2 API implementation is not yet available")
278-
279-
def get_users(self, uploader_ids: list[str]) -> dict:
280-
"""
281-
Retrieve usernames for a list of OpenML user IDs using the v2 API.
282-
283-
Notes
284-
-----
285-
This method is not yet implemented.
286-
"""
287-
raise NotImplementedError("V2 API implementation is not yet available")

0 commit comments

Comments
 (0)