From 8c3afa3074475243dc28e3d064aa8b550a3fd868 Mon Sep 17 00:00:00 2001 From: VariableVince <24507472+VariableVince@users.noreply.github.com> Date: Wed, 29 Jul 2026 23:35:47 +0200 Subject: [PATCH] Add the missing silo-built sound effect. The sound file was already present in the repo. Just never put in sound controller. It really seems to have been overlooked when approving sounds in https://github.com/openfrontio/OpenFrontIO/pull/3394. The other unapproved files seem to actually not (yet) be approved for a reason. But all other buildings emit a sound on being built, just not the missile silo and that's why it genuinly seems overlooked. --- src/client/controllers/SoundEffectController.ts | 3 +++ src/client/sound/Sounds.ts | 2 ++ 2 files changed, 5 insertions(+) diff --git a/src/client/controllers/SoundEffectController.ts b/src/client/controllers/SoundEffectController.ts index 6ed8563fde..320891d48f 100644 --- a/src/client/controllers/SoundEffectController.ts +++ b/src/client/controllers/SoundEffectController.ts @@ -91,6 +91,9 @@ export class SoundEffectController implements Controller { case UnitType.SAMLauncher: if (unit.owner() === myPlayer) this.emit("sam-built"); break; + case UnitType.MissileSilo: + if (unit.owner() === myPlayer) this.emit("silo-built"); + break; } } diff --git a/src/client/sound/Sounds.ts b/src/client/sound/Sounds.ts index f80e061023..7368d45920 100644 --- a/src/client/sound/Sounds.ts +++ b/src/client/sound/Sounds.ts @@ -15,6 +15,7 @@ export type SoundEffect = | "build-defense-post" | "build-warship" | "sam-built" + | "silo-built" | "message" | "click"; @@ -32,6 +33,7 @@ export const soundEffectUrls: ReadonlyMap = new Map([ ["build-defense-post", assetUrl("sounds/effects/build-defense-post.mp3")], ["build-warship", assetUrl("sounds/effects/build-warship.mp3")], ["sam-built", assetUrl("sounds/effects/sam-built.mp3")], + ["silo-built", assetUrl("sounds/effects/silo-built.mp3")], ["message", assetUrl("sounds/effects/message.mp3")], ["click", assetUrl("sounds/effects/click.mp3")], ]);