Renamed enum case name to better describe its function

Author: ok200paul

app/Enums/ApiResponse.php

@@ -32,7 +32,7 @@ enum ApiResponse: string
     case RESPONSE_REDEMPTION_FAILED_VOUCHER_ALREADY_FULLY_REDEEMED      = 'This voucher has already been fully redeemed, no redemption made this time.';
     case RESPONSE_REDEMPTION_FAILED_REQUESTED_AMOUNT_TOO_HIGH           = 'Requested amount is greater than voucher value remaining, no redemption made this time.';
     case RESPONSE_REDEMPTION_FAILED_TOO_MANY_ATTEMPTS                   = 'Too many redemption attempts, please wait.';
-    case RESPONSE_REDEMPTION_FAILED_VOUCHER_EXPIRED                     = 'This voucher has expired.';
+    case RESPONSE_VOUCHER_EXPIRED                                       = 'This voucher has expired.';
     case RESPONSE_REDEMPTION_LIVE_REDEMPTION                            = 'Please provide the customer with their goods / services to the value of XXX.';
     case RESPONSE_REDEMPTION_TEST_REDEMPTION                            = 'This was a test redemption. Do NOT provide the person with goods or services.';
     case RESPONSE_REDEMPTION_SUCCESSFUL                                 = 'Redemption successful.';

app/Http/Controllers/Api/V1/ApiVoucherRedemptionsController.php

@@ -166,7 +166,7 @@ public function store(): JsonResponse
             if (!is_null($voucher->expires_at)) {
                 if ($voucher->expires_at <= now()) {
                     $this->responseCode = 400;
-                    $this->message      = ApiResponse::RESPONSE_REDEMPTION_FAILED_VOUCHER_EXPIRED->value;
+                    $this->message      = ApiResponse::RESPONSE_VOUCHER_EXPIRED->value;
 
                     return $this->respond();
                 }

app/Http/Controllers/Api/V1/ApiVoucherValidationController.php

@@ -148,7 +148,7 @@ public function store(): JsonResponse
             if (!is_null($voucher->expires_at)) {
                 if ($voucher->expires_at <= now()) {
                     $this->responseCode = 409;
-                    $this->message      = ApiResponse::RESPONSE_REDEMPTION_FAILED_VOUCHER_EXPIRED->value;
+                    $this->message      = ApiResponse::RESPONSE_VOUCHER_EXPIRED->value;
 
                     return $this->respond();
                 }

tests/Feature/API/App/VoucherRedemption/VoucherRedemptionPostTest.php

@@ -375,6 +375,6 @@ public function itFailsIfVoucherHasExpired()
         $response->assertStatus(400);
 
         $responseObject = json_decode($response->getContent(), false);
-        $this->assertSame(ApiResponse::RESPONSE_REDEMPTION_FAILED_VOUCHER_EXPIRED->value, $responseObject->meta->message);
+        $this->assertSame(ApiResponse::RESPONSE_VOUCHER_EXPIRED->value, $responseObject->meta->message);
     }
 }

tests/Feature/API/App/VoucherValidation/VoucherValidationPostTest.php

@@ -206,7 +206,7 @@ public function itFailsIfVoucherIsExpired()
          * Assert status code & message are expected
          */
         $response->assertStatus(409);
-        $this->assertEquals($responseObject->meta->message, ApiResponse::RESPONSE_REDEMPTION_FAILED_VOUCHER_EXPIRED->value);
+        $this->assertEquals($responseObject->meta->message, ApiResponse::RESPONSE_VOUCHER_EXPIRED->value);
     }
 
     #[Test]