fix funky string access

Author: andiwand

pdf2htmlEX/src/BackgroundRenderer/CairoBackgroundRenderer.cc

@@ -130,11 +130,10 @@ bool CairoBackgroundRenderer::render_page(PDFDoc * doc, int pageno)
     if (doc->getPageRotate(pageno) == 90 || doc->getPageRotate(pageno) == 270)
         std::swap(page_height, page_width);
 
-    
-    std::string tmp_fn = html_renderer->str_fmt("%s/tmp_bg%x.%s", (param.embed_image ? param.tmp_dir : param.dest_dir).c_str(), pageno, format.c_str());
-    std::string fn = html_renderer->str_fmt("%s/bg%x.%s", (param.embed_image ? param.tmp_dir : param.dest_dir).c_str(), pageno, format.c_str());
+    auto tmp_fn = html_renderer->str_fmt("%s/tmp_bg%x.%s", (param.embed_image ? param.tmp_dir : param.dest_dir).c_str(), pageno, format.c_str());
+    auto fn = html_renderer->str_fmt("%s/bg%x.%s", (param.embed_image ? param.tmp_dir : param.dest_dir).c_str(), pageno, format.c_str());
 
-    surface = cairo_svg_surface_create(tmp_fn.c_str(), page_width * param.actual_dpi / DEFAULT_DPI, page_height * param.actual_dpi / DEFAULT_DPI);
+    surface = cairo_svg_surface_create((const char *)tmp_fn, page_width * param.actual_dpi / DEFAULT_DPI, page_height * param.actual_dpi / DEFAULT_DPI);
     cairo_svg_surface_restrict_to_version(surface, CAIRO_SVG_VERSION_1_2);
     cairo_surface_set_fallback_resolution(surface, param.actual_dpi, param.actual_dpi);
 
@@ -174,7 +173,7 @@ bool CairoBackgroundRenderer::render_page(PDFDoc * doc, int pageno)
     {
         int n = 0;
         char c;
-        ifstream svgfile(tmp_fn);
+        ifstream svgfile((const char *)tmp_fn);
         //count of '<' in the file should be an approximation of node count.
         while(svgfile >> c)
         {
@@ -191,10 +190,10 @@ bool CairoBackgroundRenderer::render_page(PDFDoc * doc, int pageno)
     for (auto id : bitmaps_in_current_page)
         ++bitmaps_ref_count[id];
 
-    std::rename(tmp_fn.c_str(), fn.c_str());
+    std::rename((const char *)tmp_fn, (const char *)fn);
 
     if(param.embed_image)
-        html_renderer->tmp_files.add(fn);
+        html_renderer->tmp_files.add((const char *)fn);
 
     return true;
 }

pdf2htmlEX/src/BackgroundRenderer/SplashBackgroundRenderer.cc

@@ -114,8 +114,8 @@ bool SplashBackgroundRenderer::render_page(PDFDoc * doc, int pageno)
 
     auto * bitmap = getBitmap();
 
-    std::string tmp_fn = html_renderer->str_fmt("%s/tmp_bg%x.%s", (param.embed_image ? param.tmp_dir : param.dest_dir).c_str(), pageno, format.c_str());
-    std::string fn = html_renderer->str_fmt("%s/bg%x.%s", (param.embed_image ? param.tmp_dir : param.dest_dir).c_str(), pageno, format.c_str());
+    auto tmp_fn = html_renderer->str_fmt("%s/tmp_bg%x.%s", (param.embed_image ? param.tmp_dir : param.dest_dir).c_str(), pageno, format.c_str());
+    auto fn = html_renderer->str_fmt("%s/bg%x.%s", (param.embed_image ? param.tmp_dir : param.dest_dir).c_str(), pageno, format.c_str());
 
     SplashImageFileFormat splashImageFileFormat;
     if(format == "png")
@@ -125,14 +125,14 @@ bool SplashBackgroundRenderer::render_page(PDFDoc * doc, int pageno)
     else
         throw string("Image format not supported: ") + format;
 
-    SplashError e = bitmap->writeImgFile(splashImageFileFormat, tmp_fn.c_str(), param.actual_dpi, param.actual_dpi);
+    SplashError e = bitmap->writeImgFile(splashImageFileFormat, (const char *)tmp_fn, param.actual_dpi, param.actual_dpi);
     if (e != splashOk)
         throw string("Cannot write background image. SplashErrorCode: ") + std::to_string(e);
 
-    std::rename(tmp_fn.c_str(), fn.c_str());
+    std::rename((const char *)tmp_fn, (const char *)fn);
 
     if(param.embed_image)
-        html_renderer->tmp_files.add(fn);
+        html_renderer->tmp_files.add((const char *)fn);
 
     return true;
 }