drop phantomjs

Author: andiwand

Dockerfile

@@ -1,7 +1,6 @@
 FROM --platform=linux/amd64 ubuntu:24.04
 
 ENV FIREFOX_VERSION="138.0.4"
-ENV PHANTOMJS_VERSION="2.1.1"
 ENV GECKODRIVER_VERSION="0.36.0"
 
 ENV INSTALL="apt-get install -y --no-install-recommends"
@@ -37,21 +36,6 @@ RUN wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.d
 
 RUN google-chrome --version
 
-# phantomjs setup
-RUN $INSTALL build-essential chrpath libssl-dev libxft-dev \
-    libfreetype6 libfreetype6-dev libfontconfig1 libfontconfig1-dev
-
-RUN wget https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-${PHANTOMJS_VERSION}-linux-x86_64.tar.bz2 && \
-    tar -xf phantomjs-${PHANTOMJS_VERSION}-linux-x86_64.tar.bz2 && \
-    mv phantomjs-${PHANTOMJS_VERSION}-linux-x86_64/bin/phantomjs /usr/local/bin && \
-    rm -rf phantomjs-${PHANTOMJS_VERSION}-linux-x86_64 && \
-    rm phantomjs-${PHANTOMJS_VERSION}-linux-x86_64.tar.bz2
-
-# fix weird phantomjs issue
-ENV OPENSSL_CONF=/etc/ssl
-
-RUN phantomjs --version
-
 # install python dependencies
 COPY . /compare-html
 RUN $INSTALL python3 python3-pip && \

src/htmlcmp/compare_output.py

@@ -241,9 +241,7 @@ def main():
     parser = argparse.ArgumentParser()
     parser.add_argument("a", type=Path, help="Path to the first directory")
     parser.add_argument("b", type=Path, help="Path to the second directory")
-    parser.add_argument(
-        "--driver", choices=["chrome", "firefox", "phantomjs"], default="firefox"
-    )
+    parser.add_argument("--driver", choices=["chrome", "firefox"], default="firefox")
     parser.add_argument(
         "--diff-output", type=Path, help="Output directory for diff images"
     )

src/htmlcmp/compare_output_server.py

@@ -698,7 +698,7 @@ def main():
     parser = argparse.ArgumentParser()
     parser.add_argument("ref", type=Path, help="Path to the reference directory")
     parser.add_argument("mon", type=Path, help="Path to the monitored directory")
-    parser.add_argument("--driver", choices=["chrome", "firefox", "phantomjs"])
+    parser.add_argument("--driver", choices=["chrome", "firefox"])
     parser.add_argument("--max-workers", type=int, default=1)
     parser.add_argument("--compare", action="store_true")
     parser.add_argument("--port", type=int, default=5000)

src/htmlcmp/html_render_diff.py

@@ -70,11 +70,7 @@ def get_browser(
             f"Expected int for max_width and max_height, got {type(max_width)} and {type(max_height)}"
         )
 
-    if driver == "phantomjs":
-        if shutil.which("phantomjs") is None:
-            raise EnvironmentError("PhantomJS is not installed or not found in PATH")
-        browser = webdriver.PhantomJS()
-    elif driver == "firefox":
+    if driver == "firefox":
         options = webdriver.FirefoxOptions()
         options.add_argument("--headless")
         browser = webdriver.Firefox(options=options)
@@ -109,9 +105,7 @@ def main():
     parser = argparse.ArgumentParser()
     parser.add_argument("a", type=Path, help="Path to the first HTML file")
     parser.add_argument("b", type=Path, help="Path to the second HTML file")
-    parser.add_argument(
-        "--driver", choices=["chrome", "firefox", "phantomjs"], default="firefox"
-    )
+    parser.add_argument("--driver", choices=["chrome", "firefox"], default="firefox")
     parser.add_argument("--max-width", default=1000)
     parser.add_argument("--max-height", default=10000)
     args = parser.parse_args()

tests/test_html_render_diff.py

@@ -31,12 +31,6 @@ def test_get_browser():
     assert browser.name == "firefox"
     browser.quit()
 
-    # Test with PhantomJS
-    if shutil.which("phantomjs") is not None:
-        browser = get_browser("phantomjs")
-        assert browser.name == "phantomjs"
-        browser.quit()
-
 
 def test_html_render_diff():
     test1 = Path(__file__).parent / "test1.html"