Skip to content

Commit 7144ed9

Browse files
authored
cleanup useless tests (#93) (#100)
* chore: remove old way to generate cmp benchtests * chore: remove old tests that now are generated by testgen * chore: remove old end-to-end test generator * chore: remove old end-to-end tests generated by hand * doc: update testgen readme
1 parent 4fd63b7 commit 7144ed9

29 files changed

Lines changed: 58 additions & 4256 deletions

Makefile

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ build: clean
3131

3232
testgen:
3333
@echo "Generating tests"
34-
cd testgen/ && rm -f generated_*.go && go run *.go && mv generated_endtoend_*tests.go ../tests/endtoend/ && mv generated_validation_*_test.go ../internal/codegenerator/ && mv generated_function_code_*_test.go ../internal/codegenerator/ && mv generated_cmp_perf_*.go ../tests/cmpbenchtests/generated_tests/
34+
cd testgen/ && rm -f generated_*.go && go run *.go && mv generated_endtoend_*tests.go ../tests/endtoend/ && mv generated_validation_*_test.go ../internal/codegenerator/ && mv generated_function_code_*_test.go ../internal/codegenerator/ && mv generated_cmp_perf_*.go ../tests/cmpbenchtests/
3535

3636
endtoendtests: build
3737
@echo "Running endtoend tests"
@@ -41,11 +41,9 @@ endtoendtests: build
4141

4242
cmpbenchtests: build
4343
@echo "Running cmp bench tests"
44-
rm -f tests/cmpbenchtests/generated_tests/valid*.go && rm -f tests/cmpbenchtests/generated_tests/types.go
45-
cd tests/cmpbenchtests; go run .
46-
$(VALIDGEN_BIN) tests/cmpbenchtests/generated_tests
44+
$(VALIDGEN_BIN) tests/cmpbenchtests/
4745
go clean -testcache
48-
go test -bench=. -v -benchmem -benchtime=$(BENCH_TIME) ./tests/cmpbenchtests/generated_tests
46+
go test -bench=. -v -benchmem -benchtime=$(BENCH_TIME) ./tests/cmpbenchtests/
4947

5048
setup:
5149
@echo "Setting up"

internal/codegenerator/build_func_validator_test.go

Lines changed: 1 addition & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import (
99
"github.com/sergi/go-diff/diffmatchpatch"
1010
)
1111

12-
func TestBuildFuncValidatorCode(t *testing.T) {
12+
func TestBuildFuncValidatorCodeFieldOperations(t *testing.T) {
1313
type fields struct {
1414
Struct *analyzer.Struct
1515
}
@@ -18,79 +18,6 @@ func TestBuildFuncValidatorCode(t *testing.T) {
1818
fields fields
1919
want string
2020
}{
21-
{
22-
name: "Valid struct",
23-
fields: fields{
24-
Struct: &analyzer.Struct{
25-
Struct: parser.Struct{
26-
PackageName: "main",
27-
StructName: "User",
28-
Fields: []parser.Field{
29-
{
30-
FieldName: "FirstName",
31-
Type: common.FieldType{BaseType: "string"},
32-
Tag: `validate:"required"`,
33-
},
34-
{
35-
FieldName: "MyAge",
36-
Type: common.FieldType{BaseType: "uint8"},
37-
Tag: `validate:"required"`,
38-
},
39-
},
40-
},
41-
FieldsValidations: []analyzer.FieldValidations{
42-
{
43-
Validations: []*analyzer.Validation{AssertParserValidation(t, "required")},
44-
},
45-
{
46-
Validations: []*analyzer.Validation{AssertParserValidation(t, "required")},
47-
},
48-
},
49-
},
50-
},
51-
want: `func UserValidate(obj *User) []error {
52-
var errs []error
53-
if !(obj.FirstName != "") {
54-
errs = append(errs, types.NewValidationError("FirstName is required"))
55-
}
56-
if !(obj.MyAge != 0) {
57-
errs = append(errs, types.NewValidationError("MyAge is required"))
58-
}
59-
return errs
60-
}
61-
`,
62-
},
63-
{
64-
name: "FirstName must have 5 characters or more",
65-
fields: fields{
66-
Struct: &analyzer.Struct{
67-
Struct: parser.Struct{
68-
PackageName: "main",
69-
StructName: "User",
70-
Fields: []parser.Field{
71-
{
72-
FieldName: "FirstName",
73-
Type: common.FieldType{BaseType: "string"},
74-
Tag: `validate:"min=5"`,
75-
},
76-
},
77-
},
78-
FieldsValidations: []analyzer.FieldValidations{
79-
{
80-
Validations: []*analyzer.Validation{AssertParserValidation(t, "min=5")},
81-
},
82-
},
83-
},
84-
},
85-
want: `func UserValidate(obj *User) []error {
86-
var errs []error
87-
if !(len(obj.FirstName) >= 5) {
88-
errs = append(errs, types.NewValidationError("FirstName length must be >= 5"))
89-
}
90-
return errs
91-
}
92-
`,
93-
},
9421
{
9522
name: "Field inner op",
9623
fields: fields{

0 commit comments

Comments
 (0)