-
Notifications
You must be signed in to change notification settings - Fork 2
Expand file tree
/
Copy pathbuild_validator_test.go
More file actions
521 lines (504 loc) · 14.7 KB
/
build_validator_test.go
File metadata and controls
521 lines (504 loc) · 14.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
package codegenerator
import (
"fmt"
"testing"
"github.com/opencodeco/validgen/internal/analyzer"
"github.com/opencodeco/validgen/internal/common"
"github.com/opencodeco/validgen/internal/parser"
)
func TestBuildValidationCodeOld(t *testing.T) {
type args struct {
fieldName string
fieldType common.FieldType
fieldValidation string
}
tests := []struct {
name string
args args
want string
}{
{
name: "if code with string",
args: args{
fieldName: "strField",
fieldType: common.FieldType{BaseType: "string"},
fieldValidation: "eq=abc",
},
want: `if !(obj.strField == "abc") {
errs = append(errs, types.NewValidationError("strField must be equal to 'abc'"))
}
`,
},
{
name: "if code with uint8",
args: args{
fieldName: "intField",
fieldType: common.FieldType{BaseType: "uint8"},
fieldValidation: "gte=123",
},
want: `if !(obj.intField >= 123) {
errs = append(errs, types.NewValidationError("intField must be >= 123"))
}
`,
},
{
name: "if code with string and in",
args: args{
fieldName: "strField",
fieldType: common.FieldType{BaseType: "string"},
fieldValidation: "in=a b c",
},
want: `if !(obj.strField == "a" || obj.strField == "b" || obj.strField == "c") {
errs = append(errs, types.NewValidationError("strField must be one of 'a' 'b' 'c'"))
}
`,
},
{
name: "if code with string and not in",
args: args{
fieldName: "strField",
fieldType: common.FieldType{BaseType: "string"},
fieldValidation: "nin=a b c",
},
want: `if !(obj.strField != "a" && obj.strField != "b" && obj.strField != "c") {
errs = append(errs, types.NewValidationError("strField must not be one of 'a' 'b' 'c'"))
}
`,
},
{
name: "Required slice string",
args: args{
fieldName: "strField",
fieldType: common.FieldType{BaseType: "string", ComposedType: "[]"},
fieldValidation: "required",
},
want: `if !(len(obj.strField) != 0) {
errs = append(errs, types.NewValidationError("strField must not be empty"))
}
`,
},
{
name: "Min slice string",
args: args{
fieldName: "strField",
fieldType: common.FieldType{BaseType: "string", ComposedType: "[]"},
fieldValidation: "min=2",
},
want: `if !(len(obj.strField) >= 2) {
errs = append(errs, types.NewValidationError("strField must have at least 2 elements"))
}
`,
},
{
name: "Max slice string",
args: args{
fieldName: "strField",
fieldType: common.FieldType{BaseType: "string", ComposedType: "[]"},
fieldValidation: "max=5",
},
want: `if !(len(obj.strField) <= 5) {
errs = append(errs, types.NewValidationError("strField must have at most 5 elements"))
}
`,
},
{
name: "Len slice string",
args: args{
fieldName: "strField",
fieldType: common.FieldType{BaseType: "string", ComposedType: "[]"},
fieldValidation: "len=3",
},
want: `if !(len(obj.strField) == 3) {
errs = append(errs, types.NewValidationError("strField must have exactly 3 elements"))
}
`,
},
{
name: "In slice string",
args: args{
fieldName: "strField",
fieldType: common.FieldType{BaseType: "string", ComposedType: "[]"},
fieldValidation: "in=a b c",
},
want: `if !(types.SliceOnlyContains(obj.strField, []string{"a", "b", "c"})) {
errs = append(errs, types.NewValidationError("strField elements must be one of 'a' 'b' 'c'"))
}
`,
},
{
name: "Not in slice string",
args: args{
fieldName: "strField",
fieldType: common.FieldType{BaseType: "string", ComposedType: "[]"},
fieldValidation: "nin=a b c",
},
want: `if !(types.SliceNotContains(obj.strField, []string{"a", "b", "c"})) {
errs = append(errs, types.NewValidationError("strField elements must not be one of 'a' 'b' 'c'"))
}
`,
},
{
name: "In array string",
args: args{
fieldName: "strField",
fieldType: common.FieldType{BaseType: "string", ComposedType: "[N]"},
fieldValidation: "in=a b c",
},
want: `if !(types.SliceOnlyContains(obj.strField[:], []string{"a", "b", "c"})) {
errs = append(errs, types.NewValidationError("strField elements must be one of 'a' 'b' 'c'"))
}
`,
},
{
name: "Not in array string",
args: args{
fieldName: "strField",
fieldType: common.FieldType{BaseType: "string", ComposedType: "[N]"},
fieldValidation: "nin=a b c",
},
want: `if !(types.SliceNotContains(obj.strField[:], []string{"a", "b", "c"})) {
errs = append(errs, types.NewValidationError("strField elements must not be one of 'a' 'b' 'c'"))
}
`,
},
{
name: "inner field operation",
args: args{
fieldName: "field1",
fieldType: common.FieldType{BaseType: "string"},
fieldValidation: "eqfield=field2",
},
want: `if !(obj.field1 == obj.field2) {
errs = append(errs, types.NewValidationError("field1 must be equal to field2"))
}
`,
},
{
name: "nested field operation",
args: args{
fieldName: "field1",
fieldType: common.FieldType{BaseType: "string"},
fieldValidation: "eqfield=Nested.field2",
},
want: `if !(obj.field1 == obj.Nested.field2) {
errs = append(errs, types.NewValidationError("field1 must be equal to Nested.field2"))
}
`,
},
{
name: "if code with bool",
args: args{
fieldName: "boolField",
fieldType: common.FieldType{BaseType: "bool"},
fieldValidation: "eq=true",
},
want: `if !(obj.boolField == true) {
errs = append(errs, types.NewValidationError("boolField must be equal to true"))
}
`,
},
{
name: "if code with int",
args: args{
fieldName: "intField",
fieldType: common.FieldType{BaseType: "int"},
fieldValidation: "eq=5",
},
want: `if !(obj.intField == 5) {
errs = append(errs, types.NewValidationError("intField must be equal to 5"))
}
`,
},
{
name: "if code with float32",
args: args{
fieldName: "floatField",
fieldType: common.FieldType{BaseType: "float32"},
fieldValidation: "eq=5.0",
},
want: `if !(obj.floatField == 5.0) {
errs = append(errs, types.NewValidationError("floatField must be equal to 5.0"))
}
`,
},
// Map type
{
name: "if code with string map",
args: args{
fieldName: "mapField",
fieldType: common.FieldType{BaseType: "string", ComposedType: "map"},
fieldValidation: "len=3",
},
want: `if !(len(obj.mapField) == 3) {
errs = append(errs, types.NewValidationError("mapField must have exactly 3 elements"))
}
`,
},
{
name: "if code with uint8 map",
args: args{
fieldName: "mapField",
fieldType: common.FieldType{BaseType: "uint8", ComposedType: "map"},
fieldValidation: "len=3",
},
want: `if !(len(obj.mapField) == 3) {
errs = append(errs, types.NewValidationError("mapField must have exactly 3 elements"))
}
`,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
gv := GenValidations{}
validation := AssertParserValidation(t, tt.args.fieldValidation)
got, err := gv.BuildValidationCode(tt.args.fieldName, tt.args.fieldType, []*analyzer.Validation{validation})
if err != nil {
t.Errorf("BuildValidationCode() error = %v, wantErr %v", err, nil)
return
}
if got != tt.want {
t.Errorf("BuildValidationCode() = %v, want %v", got, tt.want)
}
})
}
}
func TestBuildValidationCodeWithNestedStructsAndSlices(t *testing.T) {
type args struct {
fieldName string
fieldType common.FieldType
fieldValidation string
}
tests := []struct {
name string
args args
want string
}{
{
name: "test code with inner struct",
args: args{
fieldName: "Field",
fieldType: common.FieldType{BaseType: "main.InnerStructType"},
fieldValidation: "required",
},
want: "errs = append(errs, InnerStructTypeValidate(&obj.Field)...)\n",
},
{
name: "test code with inner struct in another package",
args: args{
fieldName: "Field",
fieldType: common.FieldType{BaseType: "mypkg.InnerStructType"},
fieldValidation: "required",
},
want: "errs = append(errs, mypkg.InnerStructTypeValidate(&obj.Field)...)\n",
},
{
name: "test code with required slice of string",
args: args{
fieldName: "Field",
fieldType: common.FieldType{BaseType: "string", ComposedType: "[]"},
fieldValidation: "required",
},
want: `if !(len(obj.Field) != 0) {
errs = append(errs, types.NewValidationError("Field must not be empty"))
}
`,
},
{
name: "test code with min slice of string",
args: args{
fieldName: "Field",
fieldType: common.FieldType{BaseType: "string", ComposedType: "[]"},
fieldValidation: "min=2",
},
want: `if !(len(obj.Field) >= 2) {
errs = append(errs, types.NewValidationError("Field must have at least 2 elements"))
}
`,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
gv := GenValidations{
Struct: &analyzer.Struct{
Struct: parser.Struct{
PackageName: "main",
},
},
StructsWithValidation: map[string]struct{}{},
}
gv.StructsWithValidation[tt.args.fieldType.BaseType] = struct{}{}
validation := AssertParserValidation(t, tt.args.fieldValidation)
got, err := gv.BuildValidationCode(tt.args.fieldName, tt.args.fieldType, []*analyzer.Validation{validation})
if err != nil {
t.Errorf("BuildValidationCode() error = %v, wantErr %v", err, nil)
return
}
if got != tt.want {
t.Errorf("BuildValidationCode() = %v, want %v", got, tt.want)
}
})
}
}
func TestBuildValidationCodeWithPointerTypes(t *testing.T) {
tests := []struct {
fieldType common.FieldType
validation string
want string
}{
// Pointer basic types.
{
fieldType: common.FieldType{BaseType: "string", ComposedType: "*"},
validation: "eq=abc",
want: `if !(obj.field != nil && *obj.field == "abc") {
errs = append(errs, types.NewValidationError("field must be equal to 'abc'"))
}
`,
},
{
fieldType: common.FieldType{BaseType: "bool", ComposedType: "*"},
validation: "eq=true",
want: `if !(obj.field != nil && *obj.field == true) {
errs = append(errs, types.NewValidationError("field must be equal to true"))
}
`,
},
{
fieldType: common.FieldType{BaseType: "int", ComposedType: "*"},
validation: "eq=5",
want: `if !(obj.field != nil && *obj.field == 5) {
errs = append(errs, types.NewValidationError("field must be equal to 5"))
}
`,
},
{
fieldType: common.FieldType{BaseType: "float32", ComposedType: "*"},
validation: "eq=5.0",
want: `if !(obj.field != nil && *obj.field == 5.0) {
errs = append(errs, types.NewValidationError("field must be equal to 5.0"))
}
`,
},
{
fieldType: common.FieldType{BaseType: "bool", ComposedType: "*"},
validation: "eq=true",
want: `if !(obj.field != nil && *obj.field == true) {
errs = append(errs, types.NewValidationError("field must be equal to true"))
}
`,
},
// Slice pointer types.
{
fieldType: common.FieldType{BaseType: "string", ComposedType: "*[]"},
validation: "required",
want: `if !(obj.field != nil && len(*obj.field) != 0) {
errs = append(errs, types.NewValidationError("field must not be empty"))
}
`,
},
{
fieldType: common.FieldType{BaseType: "int", ComposedType: "*[]"},
validation: "min=10",
want: `if !(obj.field != nil && len(*obj.field) >= 10) {
errs = append(errs, types.NewValidationError("field must have at least 10 elements"))
}
`,
},
{
fieldType: common.FieldType{BaseType: "float32", ComposedType: "*[]"},
validation: "in=10.0 12.0 14.0",
want: `if !(obj.field != nil && types.SliceOnlyContains(*obj.field, []float32{10.0, 12.0, 14.0})) {
errs = append(errs, types.NewValidationError("field elements must be one of '10.0' '12.0' '14.0'"))
}
`,
},
{
fieldType: common.FieldType{BaseType: "bool", ComposedType: "*[]"},
validation: "min=3",
want: `if !(obj.field != nil && len(*obj.field) >= 3) {
errs = append(errs, types.NewValidationError("field must have at least 3 elements"))
}
`,
},
// Array pointer types.
{
fieldType: common.FieldType{BaseType: "string", ComposedType: "*[N]"},
validation: "in=a b c",
want: `if !(obj.field != nil && types.SliceOnlyContains(obj.field[:], []string{"a", "b", "c"})) {
errs = append(errs, types.NewValidationError("field elements must be one of 'a' 'b' 'c'"))
}
`,
},
{
fieldType: common.FieldType{BaseType: "int", ComposedType: "*[N]"},
validation: "in=1 2 3",
want: `if !(obj.field != nil && types.SliceOnlyContains(obj.field[:], []int{1, 2, 3})) {
errs = append(errs, types.NewValidationError("field elements must be one of '1' '2' '3'"))
}
`,
},
{
fieldType: common.FieldType{BaseType: "float32", ComposedType: "*[N]"},
validation: "in=1.1 2.2 3.3",
want: `if !(obj.field != nil && types.SliceOnlyContains(obj.field[:], []float32{1.1, 2.2, 3.3})) {
errs = append(errs, types.NewValidationError("field elements must be one of '1.1' '2.2' '3.3'"))
}
`,
},
{
fieldType: common.FieldType{BaseType: "bool", ComposedType: "*[N]"},
validation: "in=true",
want: `if !(obj.field != nil && types.SliceOnlyContains(obj.field[:], []bool{true})) {
errs = append(errs, types.NewValidationError("field elements must be one of 'true'"))
}
`,
},
// Map pointer types.
{
fieldType: common.FieldType{BaseType: "string", ComposedType: "*map"},
validation: "len=3",
want: `if !(obj.field != nil && len(*obj.field) == 3) {
errs = append(errs, types.NewValidationError("field must have exactly 3 elements"))
}
`,
},
{
fieldType: common.FieldType{BaseType: "int", ComposedType: "*map"},
validation: "len=3",
want: `if !(obj.field != nil && len(*obj.field) == 3) {
errs = append(errs, types.NewValidationError("field must have exactly 3 elements"))
}
`,
},
{
fieldType: common.FieldType{BaseType: "float32", ComposedType: "*map"},
validation: "len=3",
want: `if !(obj.field != nil && len(*obj.field) == 3) {
errs = append(errs, types.NewValidationError("field must have exactly 3 elements"))
}
`,
},
{
fieldType: common.FieldType{BaseType: "bool", ComposedType: "*map"},
validation: "len=3",
want: `if !(obj.field != nil && len(*obj.field) == 3) {
errs = append(errs, types.NewValidationError("field must have exactly 3 elements"))
}
`,
},
}
for _, tt := range tests {
testName := fmt.Sprintf("validation: %s with %s (%s)", tt.validation, tt.fieldType.ToGenericType(), tt.fieldType.ToNormalizedString())
t.Run(testName, func(t *testing.T) {
gv := GenValidations{}
validation := AssertParserValidation(t, tt.validation)
got, err := gv.BuildValidationCode("field", tt.fieldType, []*analyzer.Validation{validation})
if err != nil {
t.Errorf("BuildValidationCode() error = %v, wantErr %v", err, nil)
return
}
if got != tt.want {
t.Errorf("BuildValidationCode() = %v, want %v", got, tt.want)
}
})
}
}