You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
π€ This is an automated contribution from Repo Assist.
Fixes #71 β the Sound setting (Default / None / Subtle) was persisted and displayed correctly but never applied when firing toast notifications. Every toast always played the system default sound regardless of user preference.
Root cause
SettingsManager.NotificationSound was read in SettingsWindow but no toast call site in App.xaml.cs consulted it. All 14 ToastContentBuilder chains called .Show() directly.
Fix
Adds a ShowToast(ToastContentBuilder builder) helper that:
All 14 toast call sites are updated to use ShowToast(...) instead of .Show() directly.
Trade-offs
Minimal surface area: one helper, 14 call sites updated mechanically.
No new dependencies.
The ShowToast method is private and instance-level, so it has access to _settings without any parameter threading.
Test Status
WinUI build requires Windows (XAML compiler is Windows-only) β infrastructure limitation, not a code error. The OpenClaw.Shared project compiled successfully on Linux. All tests pass:
gh aw add githubnext/agentics/workflows/repo-assist.md@cbb46ab386962aa371045839fc9998ee4e97ca64
Note
This was originally intended as a pull request, but GitHub Actions is not permitted to create or approve pull requests in this repository.
The changes have been pushed to branch repo-assist/fix-issue-71-notification-sound-399f71b1abb9e069-33213a77271fa5eb.
π€ This is an automated contribution from Repo Assist.
Fixes #71 β the Sound setting (Default / None / Subtle) was persisted and displayed correctly but never applied when firing toast notifications. Every toast always played the system default sound regardless of user preference.
Root cause
SettingsManager.NotificationSoundwas read inSettingsWindowbut no toast call site inApp.xaml.csconsulted it. All 14ToastContentBuilderchains called.Show()directly.Fix
Adds a
ShowToast(ToastContentBuilder builder)helper that:builder.AddAudio(silent: true)(silent toast)builder.AddAudio(new Uri("ms-winsoundevent:Notification.IM"))All 14 toast call sites are updated to use
ShowToast(...)instead of.Show()directly.Trade-offs
ShowToastmethod is private and instance-level, so it has access to_settingswithout any parameter threading.Test Status
WinUI build requires Windows (XAML compiler is Windows-only) β infrastructure limitation, not a code error. The
OpenClaw.Sharedproject compiled successfully on Linux. All tests pass:CI runs on
windows-latestand will perform a full build verification.Closes #71
Note
This was originally intended as a pull request, but GitHub Actions is not permitted to create or approve pull requests in this repository.
The changes have been pushed to branch
repo-assist/fix-issue-71-notification-sound-399f71b1abb9e069-33213a77271fa5eb.Click here to create the pull request
To fix the permissions issue, go to Settings β Actions β General and enable Allow GitHub Actions to create and approve pull requests.
Show patch preview (237 of 237 lines)