From 6638f3dc736d43603cb3ada99ed1afc722d3d9ed Mon Sep 17 00:00:00 2001 From: Adam Perry Date: Tue, 7 Jul 2026 04:20:54 +0000 Subject: [PATCH 1/2] ci: run V8 source builds on Windows 2025 --- .github/workflows/v8-canary.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/v8-canary.yml b/.github/workflows/v8-canary.yml index 0a1cba44982..8f7962cdb58 100644 --- a/.github/workflows/v8-canary.yml +++ b/.github/workflows/v8-canary.yml @@ -314,9 +314,9 @@ jobs: fail-fast: false matrix: include: - - runner: windows-2022 + - runner: windows-2025 target: x86_64-pc-windows-msvc - - runner: windows-2022 + - runner: windows-2025 target: aarch64-pc-windows-msvc steps: From 97b47670d3d2e8d75f03a1cd73ef603900097a4a Mon Sep 17 00:00:00 2001 From: Adam Perry Date: Tue, 7 Jul 2026 18:53:04 +0000 Subject: [PATCH 2/2] codex: address PR review feedback (#31356) --- .github/workflows/v8-canary.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/v8-canary.yml b/.github/workflows/v8-canary.yml index 8f7962cdb58..d5f0133528c 100644 --- a/.github/workflows/v8-canary.yml +++ b/.github/workflows/v8-canary.yml @@ -368,9 +368,9 @@ jobs: path: | ${{ env.CARGO_TARGET_DIR }}/sccache ${{ env.CARGO_TARGET_DIR }}/${{ matrix.target }}/release/gn_out - key: rusty-v8-source-${{ matrix.target }}-sandbox-${{ hashFiles('upstream-rusty-v8/Cargo.lock', 'upstream-rusty-v8/build.rs', 'upstream-rusty-v8/git_submodule_status.txt') }} + key: rusty-v8-source-${{ matrix.target }}-${{ matrix.runner }}-sandbox-${{ hashFiles('upstream-rusty-v8/Cargo.lock', 'upstream-rusty-v8/build.rs', 'upstream-rusty-v8/git_submodule_status.txt') }} restore-keys: | - rusty-v8-source-${{ matrix.target }}-sandbox- + rusty-v8-source-${{ matrix.target }}-${{ matrix.runner }}-sandbox- - name: Install and start sccache shell: pwsh