feat: support oneOf and allOf in tool input schemas#24118
Open
celia-oai wants to merge 3 commits into
Open
Conversation
celia-oai
force-pushed
the
dev/cc/support-allof
branch
from
15d0d63 to
a850dfd
Compare
celia-oai
changed the title
Collaborator
Author
|
@codex review |
celia-oai
force-pushed
the
dev/cc/support-allof
branch
from
a850dfd to
b8d1742
Compare
Contributor
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pakrym-oai
approved these changes
May 22, 2026
celia-oai
force-pushed
the
dev/cc/support-allof
branch
from
044a09e to
2a0eef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some connector golden schemas use JSON Schema composition keywords beyond
anyOf, specifically top-level or nestedoneOfandallOf. Codex currently needs to preserve those shapes when parsing MCP tool input schemas so connector tools do not lose valid schema structure during normalization.To prevent an increased Responses API error rate, this PR will be merged after the Responses API supports top-level
oneOf/allOf.What Changed
oneOfandallOfsupport toJsonSchema, matching the existinganyOfhandling.oneOfandallOfanywhere schema children are visited, including sanitization, definition reachability, description stripping, and deep schema compaction.anyOf,oneOf, orallOfto{}if earlier compaction passes still leave the schema over budget.Validation
Golden schema token validation over
2,025schemas undergolden_schemas, all parsed successfully. Token count iso200k_baseover compact JSON fromparse_tool_input_schema.Totals:
The pruning column matches the oneOf/allOf column for this corpus because no parsed compact golden schema remains over the
4,000compact-byte budget after the earlier compaction passes.