Unchecked access to optional keys in $attributes in public static function from() in multiple classes.

[abelmannconsulting]

I am using the library not only to talk to open ai, but also to talk to azure ai agents that fully support the responses api. It looks like azure ai skips empty attributes in their response and openai does not. This causes problems in some classes where the code tries to access the array index of optional attribute without checking if it exists:

1. Example - WebSearchUserLocation.php:

The constructor shows that "city" is optional:

public readonly ?string $city

But in public static function from() the acces to it is not checked:

city: $attributes['city'],

Much better would be this:

city: $attributes['city'] ?? null,

2. Example - OutputMcpCall.php:

The construtor shows that "approvalRequestId" is optional:

public readonly ?string $approvalRequestId = null,

But the same in public static function from():

approvalRequestId: $attributes['approval_request_id'],

While this would be much better:

approvalRequestId: $attributes['approval_request_id'] ?? null,

I am not sure if you are generating this could automatically. If not I could start making pull request for all those cases where I run into a problem. Should I do that?

[iBotPeaches]

Yeah individual PRs would be great. The challenge here is we follow the OpenAI spec for all integrations and that defines the nullability of properties. So every time we null something out that another provider doesn't follow spec with we increase the burden that folks have to deal with due to our strict typing.

City & Approval Request Id seem like fine things to support as a null.

[abelmannconsulting]

Hmm ... I thought that the constructor definition follows the OpenAI spec. So when the constructor looks like this:

private function __construct(
        public readonly string $type,
        public readonly ?string $city,
        public readonly string $country,
        public readonly ?string $region,
        public readonly ?string $timezone,
    ) {}

all elements with a ? are optional and could be absent (and thus null) ... so they should not be accessed like this

public static function from(array $attributes): self
    {
        return new self(
            type: $attributes['type'],
            city: $attributes['city'],
            country: $attributes['country'],
            region: $attributes['region'],
            timezone: $attributes['timezone'],
        );
    }

without fallback ?? null

[iBotPeaches]

Makes sense. Simple bug then - surprised linter/type check didn't catch that.