Skip to content

Commit 9f298ac

Browse files
committed
improve error handling internal cp
1 parent 6f93a5e commit 9f298ac

2 files changed

Lines changed: 9 additions & 6 deletions

File tree

packages/modules/chargepoints/external_openwb/chargepoint_module.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,10 @@ def on_message(client, userdata, message):
115115
elif received_topics[f"{topic_prefix}fault_state"] == 1:
116116
self.fault_state.warning(received_topics[f"{topic_prefix}fault_str"])
117117
except KeyError:
118-
raise KeyError("Es wurden nicht alle notwendigen Daten empfangen.")
118+
if received_topics[f"{topic_prefix}fault_state"] == 2:
119+
self.fault_state.error(received_topics[f"{topic_prefix}fault_str"])
120+
else:
121+
raise KeyError("Es wurden nicht alle notwendigen Daten empfangen.")
119122
else:
120123
self.fault_state.warning(f"Keine MQTT-Daten für Ladepunkt {self.config.name} empfangen. Noch keine "
121124
"Daten nach dem Start oder Ladepunkt nicht erreichbar.")

packages/modules/internal_chargepoint_handler/clients.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,16 @@ def __init__(self,
4545

4646
def _evse_factory(self, client: Union[ModbusSerialClient_, ModbusTcpClient_], evse_ids: List[int]) -> evse.Evse:
4747
for modbus_id in evse_ids:
48-
evse_client = evse.Evse(modbus_id, client)
49-
with client:
50-
try:
48+
try:
49+
evse_client = evse.Evse(modbus_id, client)
50+
with client:
5151
if evse_client.get_firmware_version() > EVSE_MIN_FIRMWARE:
5252
log.debug(client)
5353
with ModifyLoglevelContext(log, logging.DEBUG):
5454
log.debug("Modbus-ID der EVSE an LP"+str(self.local_charge_point_num)+": "+str(modbus_id))
5555
return evse_client
56-
except Exception:
57-
pass
56+
except Exception:
57+
pass
5858
else:
5959
return None
6060

0 commit comments

Comments
 (0)