Skip to content

Commit 98eeffd

Browse files
ndrsnhsLKuemmel
authored andcommitted
GoodWe second battery; fix no attribute error (#2539)
* add second battery and update config * fix no attribute error * fix register adresses
1 parent 87620aa commit 98eeffd

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

packages/modules/devices/good_we/good_we/bat.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ def __init__(self, component_config: GoodWeBatSetup, **kwargs: Any) -> None:
2626
self.kwargs: KwargsDict = kwargs
2727

2828
def initialize(self) -> None:
29+
self.__device_id: int = self.kwargs['device_id']
2930
self.__modbus_id: int = self.kwargs['modbus_id']
3031
self.version: GoodWeVersion = self.kwargs['version']
3132
self.firmware: int = self.kwargs['firmware']
@@ -50,8 +51,8 @@ def update(self) -> None:
5051
exported = self.__tcp_client.read_holding_registers(
5152
35209, ModbusDataType.UINT_32, unit=self.__modbus_id) * 100
5253
else:
53-
power = self.__tcp_client.read_holding_registers(35182, ModbusDataType.INT_32, unit=self.__modbus_id)*-1
54-
soc = self.__tcp_client.read_holding_registers(37007, ModbusDataType.UINT_16, unit=self.__modbus_id)
54+
power = self.__tcp_client.read_holding_registers(35264, ModbusDataType.INT_32, unit=self.__modbus_id)*-1
55+
soc = self.__tcp_client.read_holding_registers(39005, ModbusDataType.UINT_16, unit=self.__modbus_id)
5556
imported, exported = self.sim_counter.sim_count(power)
5657

5758
bat_state = BatState(

packages/modules/devices/good_we/good_we/device.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ def create_device(device_config: GoodWe):
2222
def create_bat_component(component_config: GoodWeBatSetup):
2323
nonlocal client
2424
return bat.GoodWeBat(component_config=component_config,
25+
device_id=device_config.id,
2526
modbus_id=device_config.configuration.modbus_id,
2627
version=GoodWeVersion(device_config.configuration.version),
2728
firmware=device_config.configuration.firmware,

0 commit comments

Comments
 (0)