Skip to content

Commit 35dc83c

Browse files
committed
fix pytest
1 parent 81f0dd1 commit 35dc83c

1 file changed

Lines changed: 8 additions & 11 deletions

File tree

packages/modules/common/hardware_check_test.py

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -44,25 +44,22 @@ def test_hardware_check_fails(evse_side_effect,
4444
monkeypatch):
4545
# setup
4646
mock_evse_client = Mock(spec=Evse, version=18, get_evse_state=Mock(side_effect=[evse_side_effect]))
47-
mock_evse_facotry = Mock(return_value=mock_evse_client)
48-
monkeypatch.setattr(ClientHandler, "_evse_factory", mock_evse_facotry)
47+
monkeypatch.setattr(ClientHandler, "_evse_factory", Mock(return_value=mock_evse_client))
4948

50-
counter_state_mock = Mock(spec=CounterState, side_effect=meter_side_effect,
49+
counter_state_mock = Mock(spec=CounterState,
5150
voltages=meter_return_value,
5251
currents=[0, 0, 0],
5352
powers=[0, 0, 0],
5453
power=0,
5554
serial_number="1234")
56-
mock_meter_client = Mock(spec=sdm.Sdm630_72, get_counter_state=Mock(return_value=counter_state_mock))
57-
mock_find_meter_client = Mock(spec=sdm.Sdm630_72, return_value=mock_meter_client)
58-
monkeypatch.setattr(ClientHandler, "find_meter_client", mock_find_meter_client)
55+
mock_meter_client = Mock(spec=sdm.Sdm630_72, get_counter_state=Mock(
56+
side_effect=meter_side_effect, return_value=counter_state_mock))
57+
monkeypatch.setattr(ClientHandler, "find_meter_client", Mock(return_value=mock_meter_client))
5958

60-
handle_exception_mock = Mock(side_effect=handle_exception_side_effect, return_value=handle_exception_return_value)
61-
monkeypatch.setattr(SeriesHardwareCheckMixin, "handle_exception", handle_exception_mock)
59+
monkeypatch.setattr(SeriesHardwareCheckMixin, "handle_exception", Mock(
60+
side_effect=handle_exception_side_effect, return_value=handle_exception_return_value))
6261

63-
enter_mock = Mock(return_value=None)
64-
exit_mock = Mock(return_value=True)
65-
client = Mock(spec=client_spec, __enter__=enter_mock, __exit__=exit_mock)
62+
client = Mock(spec=client_spec, __enter__=Mock(return_value=None), __exit__=Mock(return_value=None))
6663

6764
# execution and evaluation
6865
with pytest.raises(Exception, match=re.escape(expected_error_msg)):

0 commit comments

Comments
 (0)