You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Weaver lacks any ability to define profiles
Describe the solution you'd like
We should be able to define profile telemetry using yaml.
Based on the proto I forsee the following definitions as being need.
the profile definition should contain:
period_kind: string ie heap
period_unit: string ie bytes
attributes: attribute ref array
sample: sample ref
The sample definition should contain:
sample_kind: string ie allocated_space
sample_unit: string ie bytes
attributes: attribute ref array
Which when resolved creates the following definition:
period_kind: string ie heap
period_unit: string ie bytes
sample_type: string
sample_kind: string ie allocated_space
sample_unit: string ie bytes
attributes: attribute array with the capture.level property distinguishing if it is sample or profile attribute as per Instrumentation scopes #1005
Describe alternatives you've considered
Not defining profiles.
Directly defining profiles in their resolved form ie no seperate samples but samples couldn't be re-used.
Additional context
Should be considered in context of v2 to ensure it is designed to support it.
Tip: React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.
Is your feature request related to a problem? Please describe.
Weaver lacks any ability to define profiles
Describe the solution you'd like
We should be able to define profile telemetry using yaml.
Based on the proto I forsee the following definitions as being need.
the profile definition should contain:
period_kind: string ie heapperiod_unit: string ie bytesattributes: attribute ref arraysample: sample refThe sample definition should contain:
sample_kind: string ie allocated_spacesample_unit: string ie bytesattributes: attribute ref arrayWhich when resolved creates the following definition:
period_kind: string ie heapperiod_unit: string ie bytessample_type: stringsample_kind: string ie allocated_spacesample_unit: string ie bytesattributes: attribute array with thecapture.levelproperty distinguishing if it issampleorprofileattribute as per Instrumentation scopes #1005Describe alternatives you've considered
Not defining profiles.
Directly defining profiles in their resolved form ie no seperate samples but samples couldn't be re-used.
Additional context
Should be considered in context of v2 to ensure it is designed to support it.
Tip: React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding
+1orme too, to help us triage it. Learn more here.