#850 Scope don't need attributes

thompson-tomo · thompson-tomo · commit 85809e285c9b · 2025-08-21T00:28:42.000+10:00
diff --git a/crates/weaver_semconv/src/group.rs b/crates/weaver_semconv/src/group.rs
@@ -162,6 +162,7 @@ impl GroupSpec {
         // All types, except metric and event, must have extends or attributes or both.
         if self.r#type != GroupType::Metric
             && self.r#type != GroupType::Event
+            && self.r#type != GroupType::Scope
             && self.extends.is_none()
             && self.attributes.is_empty()
         {

Original file line number	Diff line number	Diff line change
`@@ -162,6 +162,7 @@ impl GroupSpec {`
`162`	`162`	`// All types, except metric and event, must have extends or attributes or both.`
`163`	`163`	`if self.r#type != GroupType::Metric`
`164`	`164`	`&& self.r#type != GroupType::Event`
	`165`	`+ && self.r#type != GroupType::Scope`
`165`	`166`	`&& self.extends.is_none()`
`166`	`167`	`&& self.attributes.is_empty()`
`167`	`168`	`{`