check-links workflow warnings

[xrmx]

Github reports

.github/workflows/check-links.yml (Line: 29, Col: 9): Conditional expression contains literal text outside replacement tokens. This will cause the expression to always evaluate to truthy. Did you mean to put the entire expression inside ${{ }}?

[Manvi2402]

Hi, I've looked into this issue.

The problem was in .github/workflows/check-links.yml
at line 29 where the conditional expression had literal
text outside the ${{ }} tokens.

I've fixed it by moving the entire if condition inside
${{ }} using >- block scalar syntax.

Would love some feedback before submitting a PR!

[emdneto]

yeah noticed that. the workflow is also taking ~7m to run because when there's change to CHANGELOG.md it checks all URLs in changelog file 😅 Trying to optimize that in #4968 @Manvi2402 feel free to take it over

[Manvi2402]

Thank you @emdneto I'd love to take it over.
I'll look into #4968 and give it my best😊